GS/HW: Fix up and restore some old valid channel behaviour #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes
requires rgb/alphadetection and modifies behaviour to semi resemble the old behaviour.Rationale behind Changes
We don't really deal with the alpha channels properly if it's expecting some level of preloaded stuff, we kinda fall over. The old code used to just check if RGB was valid for normal formats, but that cause problems with games storing fonts in the alpha channel, but now the detection is improved to do similar, unless only the alpha is required, then the alpha is checked.
Suggested Testing Steps
Test random games and Hitman 2 + Tony Hawk Pro Skater 4
Fixes Tony Hawk Pro Skater 2 black screen
Fixes Hitman 2 black screen