Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Add recommended blending level for Twisted Metal: Head On #9952

Merged
merged 5 commits into from Sep 13, 2023

Conversation

Hallkezz
Copy link
Contributor

Rationale behind Changes

Fixes smoke effects for Vulkan/OpenGL.

Master:
s1

PR:
s2

Direct3D 11/12 requires minimum value of 5 to fix smoke. Should I set minimumBlendingLevel to 5?

GS dump:
GSD.zip

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Sep 12, 2023

Direct3D 11/12 requires minimum value of 5 to fix smoke. Should I set minimumBlendingLevel to 5?

I wouldn't because that will force maximum blending for every renderer and that could be slow on Vulkan/OGL, DX users will just have to know to do that (could be documented on the wiki I guess).

@RedDevilus
Copy link
Contributor

Blending will be on same level when ROV arrives so I'm scared the effects for everyone would be.

@Mrlinkwii
Copy link
Contributor

can this be set to recommended blending as per #7097 the game is heavy to run already :)

@refractionpcsx2
Copy link
Member

Yes but it will also recommend it for vulkan/ogl, which is not true.

@Hallkezz
Copy link
Contributor Author

Direct3D 11/12 requires minimum value of 5 to fix smoke. Should I set minimumBlendingLevel to 5?

I wouldn't because that will force maximum blending for every renderer and that could be slow on Vulkan/OGL, DX users will just have to know to do that (could be documented on the wiki I guess).

Okay, then we can merge this pull request and set minimumBlendingLevel at 2.

@RedDevilus
Copy link
Contributor

Direct3D 11/12 requires minimum value of 5 to fix smoke. Should I set minimumBlendingLevel to 5?

I wouldn't because that will force maximum blending for every renderer and that could be slow on Vulkan/OGL, DX users will just have to know to do that (could be documented on the wiki I guess).

Okay, then we can merge this pull request and set minimumBlendingLevel at 2.

Can you enable the OSD stats, just to make sure it won't affect certains GPUs too negatively.

@stenzek
Copy link
Member

stenzek commented Sep 13, 2023

There shouldn't be any recommendation for blend levels based on DX, because it's wrong by design, and nobody should be using it except for old Intel GPUs.

At most you want to do recommended, not minimum, because this isn't a critical rendering issue. Unless you can prove across the entire game that the added barrier count is negligible.

@Hallkezz
Copy link
Contributor Author

Direct3D 11/12 requires minimum value of 5 to fix smoke. Should I set minimumBlendingLevel to 5?

I wouldn't because that will force maximum blending for every renderer and that could be slow on Vulkan/OGL, DX users will just have to know to do that (could be documented on the wiki I guess).

Okay, then we can merge this pull request and set minimumBlendingLevel at 2.

Can you enable the OSD stats, just to make sure it won't affect certains GPUs too negatively.

Master:
s1
s2

PR:
s3
s4

@stenzek
Copy link
Member

stenzek commented Sep 13, 2023

Adding another 200 barriers isn't trivial, especially given there could be multiple of these effects on screen at once.

@Hallkezz Hallkezz changed the title GameDB: Add minimum blending level for Twisted Metal: Head On GameDB: Add recommended blending level for Twisted Metal: Head On Sep 13, 2023
@Hallkezz
Copy link
Contributor Author

Adding another 200 barriers isn't trivial, especially given there could be multiple of these effects on screen at once.

Okay, I changed minimumBlendingLevel to recommended.

@stenzek stenzek merged commit 8c65d4e into PCSX2:master Sep 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants