Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsubscribe active subscriptions on 'stop' signal. #7

Merged
merged 1 commit into from Jun 5, 2018
Merged

Unsubscribe active subscriptions on 'stop' signal. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/MessageTypes.js
View file
Open in desktop
@@ -1,4 +1,5 @@
export const GQL_START = 'start';
export const GQL_STOP = 'stop';
export const GQL_DATA = 'data';
export const GQL_ERROR = 'error';
export const GQL_COMPLETE = 'complete';
export const GQL_COMPLETE = 'complete';
9 changes: 5 additions & 4 deletions src/workerUtils.js
View file
Open in desktop
Expand Up @@ -107,11 +107,12 @@ const getOnMessage = ({ schema, context }) => {
const opId = message.id;
if (typeof opId !== 'undefined') {
switch (message.type) {
case MessageTypes.GQL_STOP:
unsubscribe(opId);
break;

case MessageTypes.GQL_START:
// if we already have a subscription with this id, unsubscribe from it first
if (connectionContext.operations && connectionContext.operations[opId]) {
unsubscribe(opId);
}
unsubscribe(opId);

const baseParams = {
query: message.payload.query,
Expand Down