Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows test failing silently #95

Closed
gsakkis opened this issue Oct 28, 2021 · 3 comments
Closed

Windows test failing silently #95

gsakkis opened this issue Oct 28, 2021 · 3 comments

Comments

@gsakkis
Copy link
Collaborator

gsakkis commented Oct 28, 2021

Just found out that the Windows CI tests have been silently failing for some time now, for example on master or on the pythonic_api PR. Moving py.test to the end reveals the failure. Apparently only the last command status code is returned, any previous failures are ignored.

By the way, the specific failure seems to be a minor bug in PDAL core:

E         -  'pipeline': [{'filename': 'test/data/1.2-with-color.las',
E         ?                                      ^
E         +  'pipeline': [{'filename': 'test/data\\1.2-with-color.las',
E         ?                                      ^^

The path in the input JSON is test/data/1.2-with-color.las and is serialized as test/data\1.2-with-color.las.

@abellgithub
Copy link
Collaborator

abellgithub commented Oct 28, 2021

I don't understand what test is failing or why.

@gsakkis
Copy link
Collaborator Author

gsakkis commented Oct 28, 2021

Let's ignore the specific test for now, I can work around it or open a new issue on PDAL. The CI issue is that exit 1; exit 0; (or whatever is the equivalent command is on Windows) succeeds.

@gsakkis
Copy link
Collaborator Author

gsakkis commented Nov 22, 2021

Fixed in afd56ea

@gsakkis gsakkis closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants