add option to display blank rows to fill to paginated number #9
Conversation
options.js
Outdated
| @@ -3,5 +3,6 @@ export default { | |||
| iconClasses: null, | |||
| iconSide: '', | |||
| searchWhen: 'onDelay', | |||
| timeoutDelay: 1000 | |||
| timeoutDelay: 1000, | |||
| showEmpty: true | |||
There was a problem hiding this comment.
I feel like this should default to false as it isn't really a function that makes sense to use in most cases.
There was a problem hiding this comment.
woops, I meant to do that. I was just testing that it worked
| @@ -98,6 +99,11 @@ | |||
| default: true | |||
| }, | |||
|
|
|||
| showEmpty: { | |||
There was a problem hiding this comment.
I would add docs to this. Its kind of a confusing functionality.
There was a problem hiding this comment.
Would add the docs into the README with everything else, that way it's all in one place.
| @@ -98,6 +99,11 @@ | |||
| default: true | |||
| }, | |||
|
|
|||
| showEmpty: { | |||
There was a problem hiding this comment.
Would add the docs into the README with everything else, that way it's all in one place.
components/Table.vue
Outdated
| @@ -261,7 +267,19 @@ | |||
| this.loading = true; | |||
| axios.get(url, { params: this.defaultParams }) | |||
| .then(response => { | |||
| this.tableData = response.data.data; | |||
| if (this.showEmpty && response.data.data.length < this.paginate) { | |||
There was a problem hiding this comment.
Might be safer to do a check on the response.data && response.data.data. I know this wasn't in here before, but would be useful.
components/Table.vue
Outdated
| ...new Array(this.paginate - response.data.data.length).fill(blank) | ||
| ] | ||
| } else { | ||
| this.tableData = response.data.data; |
No description provided.