add multiplot layout options: scale, offset, margins, spacing ; deprecate old style of speciyfing them #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cate old style of speciyfing them. previously scale & offset were provided as separate multiplot options, which were rendered as plain numbers independent of the layout option. gnuplot 5.4 doesn't recognize that syntax. they must be part of the layout option. Now, they are specified inline in the arrayref passed to the layout option.
Pull Request Test Coverage Report for Build 6694895348
💛 - Coveralls |
|
Hola out there! Any problem if I merge these? |
|
Yes. Do not go merging things please. Where are the tests of this changed functionality? |
|
Hi @djerius, are you going to add tests for this stuff? |
|
I'll get to tests shortly I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add multiplot layout options: scale, offset, margins, spacing ; deprecate old style of speciyfing them.
previously scale & offset were provided as separate multiplot options, which were rendered as plain numbers independent of the layout option. gnuplot 5.4 doesn't recognize that syntax. they must be part of the layout option.
Now, they are specified inline in the arrayref passed to the layout option.