Fix mismatch in how Gnuplot is found during configure and runtime #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `Alien::Gnuplot` as a configure-time dependency so that it finds the `gnuplot` binary the same way at configure-time that it already does at runtime. Since `Alien::Gnuplot` already checks for a working Gnuplot, `Makefile.PL` does not need to do this. This allows for overriding via the `GNUPLOT_BINARY` environment variable (e.g., for testing multiple versions of Gnuplot). Fixes <#92>.
zmughal
force-pushed
the
92-alien-gnuplot-config-dep
branch
from
61991c1
to
d100d7f
Compare
Pull Request Test Coverage Report for Build 4560878098
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Alien::Gnuplotas a configure-time dependency so that itfinds the
gnuplotbinary the same way at configure-time that italready does at runtime. Since
Alien::Gnuplotalready checks for aworking Gnuplot,
Makefile.PLdoes not need to do this.This allows for overriding via the
GNUPLOT_BINARYenvironment variable(e.g., for testing multiple versions of Gnuplot).
Fixes #92.