stop eval-ing loading driver module

PDLPorters · Apr 11, 2024 · ea83184 · ea83184
1 parent 0e04e5e
commit ea83184
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/Changes b/Changes
@@ -2,6 +2,7 @@
 - if PDL_SIMPLE_ENGINE in ENV, use ONLY that if engine unspecified
 - each driver module now publishes which $P:G:S::API_VERSION it conforms to
 - PGS::register takes hashref instead of magic var in driver namespace
+- loading driver module not eval-ed
 
 1.010 2024-03-24
 - fix PGPLOT to read devices correctly

diff --git a/lib/PDL/Graphics/Simple.pm b/lib/PDL/Graphics/Simple.pm
@@ -322,7 +322,7 @@ sub _list_submods {
 
 for my $module (_list_submods(qw(PDL Graphics Simple))) {
   (my $file = $module) =~ s/::/\//g;
-  eval { require "$file.pm"; $module->import; };
+  require "$file.pm";
 }
 $mod_abbrevs ||= _make_abbrevs($mods); # Deal with abbreviations.
 

diff --git a/lib/PDL/Graphics/Simple/Prima.pm b/lib/PDL/Graphics/Simple/Prima.pm
@@ -408,8 +408,6 @@ $types->{errorbars} = sub {
     &{$types->{limitbars}}($me, $plot, $block, $cprops, $co);
 };	  
 
-
-
 
 ##############################
 # Plot subroutine