Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert::UU dependency is now required #367

Closed
sebastic opened this issue Jan 10, 2022 · 13 comments
Closed

Convert::UU dependency is now required #367

sebastic opened this issue Jan 10, 2022 · 13 comments

Comments

@sebastic
Copy link
Contributor

Convert::UU used to be an optional dependency, but since 2.064 it is unconditionally used.

The module doesn't seem very useful as it mostly just does unpack("u", $string); and pack("u", $string);.

Can't that be done in PDL and drop the Convert::UU dependency?

@mohawk2
Copy link
Member

mohawk2 commented Jan 10, 2022

That is an excellent idea! We'll take care of it very soon.

@mohawk2
Copy link
Member

mohawk2 commented Jan 10, 2022

By the way, @sebastic we've just added an optional new dep OpenGL::GLUT, which contains a bug-fix for GLUT code that's not possible (due to no permissions being granted yet) to put in main OpenGL, and that is in any case better practice to split up a bit. I hope this doesn't cause a problem? It's optional but goes together with the optional OpenGL, and the code now needs both.

@sebastic
Copy link
Contributor Author

Only OpenGL is packaged in Debian and used for the pdl package.

OpenGL::GLUT is not packaged, and unlikely to be. If it becomes a required dependency for PDL we might be able to find someone willing to package and maintain it, but don't count on it.

@mohawk2
Copy link
Member

mohawk2 commented Jan 10, 2022

I wouldn't mind doing it myself if you can point me at resources. The bug that's fixed relates to dealing with the user closing the window during e.g. demo 3d, which is a (very - from 2006, see https://sourceforge.net/p/pdl/bugs/147/) long-standing irritant.

I'd also be interested to package original PGPLOT, unless its slightly peculiar licence would cause a problem?

@mohawk2
Copy link
Member

mohawk2 commented Jan 10, 2022

Another idea would be to make an enhanced PDL package that's got the same content as "SciPDL" (basically full PDL plus FFTW3, PGPLOT, perl FITS modules plus the deps to make the "pdl2" shell work - https://www.mail-archive.com/pdl-porters@jach.hawaii.edu/msg05839/scipdl-2.007-maverick.pod), as a Debian package called scipdl.

@sebastic
Copy link
Contributor Author

I wouldn't mind doing it myself if you can point me at resources.

Start here: https://perl-team.pages.debian.net/

And make sure to read at least the following docs linked there:

@mohawk2
Copy link
Member

mohawk2 commented Jan 10, 2022

I've just uploaded 2.065, with the Convert::UU dep replaced (thanks!).

@mohawk2
Copy link
Member

mohawk2 commented Jan 10, 2022

@sebastic I'm trying to sign in to salsa using my GitLab.com account (which does exist: https://gitlab.com/mohawk2), and it's saying "Signing in using your GitLab.com account without a pre-existing GitLab account is not allowed. Create a GitLab account first, and then connect it to your GitLab.com account" - https://wiki.debian.org/Salsa/Doc doesn't offer any clues. Can you steer me? I prefer not to have to create yet another username/password combo.

@mohawk2
Copy link
Member

mohawk2 commented Jan 10, 2022

Just uploaded 2.066 because 2.065 had an erroneous "requires" dep on OpenGL::GLUT for reasons I do not understand.

@sebastic
Copy link
Contributor Author

AFAIK you need an account on Salsa, as it is used as an identity provider in Debian:

https://wiki.debian.org/Salsa/Doc#Users

@mohawk2
Copy link
Member

mohawk2 commented Jan 11, 2022

I've registered on it, and sent the email introducing myself to debian-perl@. Let's see what happens!

@sebastic
Copy link
Contributor Author

I've just uploaded 2.065, with the Convert::UU dep replaced (thanks!).

And thank you for the quick turnaround, the Debian package builds successfully again and doesn't fail the tests.

@mohawk2
Copy link
Member

mohawk2 commented Jan 11, 2022

Thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants