Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baffioni smihits 810pre6 #35

Conversation

baffioni
Copy link

Added comparison between simhits and digi for different steps:
before and after linearisation, after trigger sums, after bestchoice, after encoding/decoding.

@jbsauvan
Copy link

@baffioni
General comments first:

  • Remove the 'cout's, or replace them with CMSSW logging functions if these printouts are really necessary
  • Remove geom_ and geom_fh_ in HGCalTriggerBestChoiceTester.cc and use the geometries (and topologies) already loaded into 'HGCalTriggerGeometryBase::es_info info' in beginRun(), which you can transform into a member of the class.

#include "SimDataFormats/CaloHit/interface/PCaloHit.h"
#include "SimDataFormats/CaloHit/interface/PCaloHitContainer.h"
#include "SimDataFormats/CaloTest/interface/HGCalTestNumbering.h"
#include "SimDataFormats/CaloTest/src/HGCalTestNumbering.cc"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove src include


HGCalTriggerGeometryBase::es_info info_;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to declare this above histograms, with geometry and service stuff

@jbsauvan jbsauvan merged commit 4c29779 into PFCal-dev:hgc-tpg-devel-CMSSW_8_1_0_pre6 Jun 23, 2016
lecriste pushed a commit that referenced this pull request Jul 1, 2019
Use CUDA Unified Addressing, and implement a CUDA-aware allocator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants