Optimize front-end processing time #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbsauvan
commented
Aug 23, 2016
jbsauvan
commented
- Reduce front-end processing time by a factor of ~1000-2000 for events without pile-up (from about 3min / evt to about 100ms / event, tested with particle guns).
- Only modules containing hits are processed, and hits in each module are preselected before the codec is called.
- It removes a double loop on all modules + all hits and replace it with a single loop on all hits followed by a double loop on selected modules and associated hits.
| } | ||
| const auto& module_ptr = triggerGeometry_->modules().at(module_hits.first); | ||
| // Association simhit energies with trigger cells | ||
| std::map<uint32_t, double> TC_simhit_energies; |
|
Thanks @lgray. |
| std::unordered_map<short, short> wafer_to_module_ee; | ||
| std::unordered_map<short, short> wafer_to_module_fh; | ||
| std::unordered_map<short, std::unordered_map<short,short>> module_to_wafers_ee; | ||
| std::unordered_map<short, std::unordered_map<short,short>> module_to_wafers_fh; |
There was a problem hiding this comment.
From the code below it looks like you can just use std::unordered_multimap<short, short>, which would be more compact in memory and faster. Any reason why not?
There was a problem hiding this comment.
Actually it just reminds me that I need an ordered iterator for the second map, e.g. line 107 (but not for the first one), so I would need unordered_map<short, map<short,short>> (or multimap<short, pair<short,short>> should work as well, but would probably be slower when searching for a module line 132).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.