Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom function and test config for standalone clustering #476

Conversation

jbsauvan
Copy link

@jbsauvan jbsauvan commented Jun 1, 2021

Adding:

  • a customization function to use the standalone clustering implementation.
  • a ntuple customization to use the cluster collection produced by the standalone clustering
  • a test config to run the standalone clustering

@jbsauvan
Copy link
Author

jbsauvan commented Jun 1, 2021

Hi @EmyrClement
Here is PR adding customization functions and test configs to use the standalone clustering. Could you cross-check that it runs as expected and that I didn't miss additional parameter changes?
Thanks!

@EmyrClement
Copy link

Hi @jbsauvan this looks ok to me and runs as expected. Should we also add the customisations to run the standalone stage 2 tower sums given the new structure exists for that?

@jbsauvan
Copy link
Author

jbsauvan commented Jun 8, 2021

Thanks @EmyrClement for the checks!
Right, I can add the tower customization as well.

@jbsauvan
Copy link
Author

jbsauvan commented Jun 9, 2021

Hi @EmyrClement
I have added a custom for the towers as well.
When runnning the standalone tower processor, I noticed that the eta and phi of the towers are always 0, and that the pT distribution is much softer.
Could you have a look?
Thanks!

@EmyrClement
Copy link

Hi @jbsauvan regarding the tower pT, this is likely because I did not include the unclustered TCs when producing the towers in the standalone wrapper - the structure of the towers code is closer to the firmware structure, but the inputs and output towers won't therefore make much sense. I ran the existing simulation with includeTrigCells set to false for the tower producer, which gives a pT distribution closer to what I get with the standalone code, but not identical. Is it worth fixing this in the standalone code?

For the eta and phi of the towers, I realised I had not carried them through the standalone code - it's straightforward to fix this.

@jbsauvan
Copy link
Author

Hi @EmyrClement
Ok, thanks. That's fine not to include the TCs; anyway I switch to not including the TCs also in the default towers (#477).
Concerning eta/phi, could you open a separate PR with the fix?

@EmyrClement
Copy link

I opened #479 to address the eta/phi fix.

@jbsauvan
Copy link
Author

Thanks @EmyrClement
I just merged #479

@jbsauvan jbsauvan merged commit 2d3e91a into PFCal-dev:hgc-tpg-devel-CMSSW_12_0_0_pre2 Jun 16, 2021
@jbsauvan jbsauvan moved this from Review to Ready for Integration in HGC L1 Simulation and Algorithms Jun 16, 2021
@jbsauvan jbsauvan moved this from Ready for Integration to Integration In Progress in HGC L1 Simulation and Algorithms Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
HGC L1 Simulation and Algorithms
Integration In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants