Distribution of trigger cells to stage 2 FPGAs

[snwebb]

PR description:

Implemented distribution of trigger cells to stage 2 FPGAs in a similar way to how it is done for stage 1.

PR validation:

Compiles and runs without errors

[snwebb]

Thanks @jbsauvan, I've made the suggested changes.

[jbsauvan]

Thanks @snwebb
Running test/testHGCalL1T_newProcessors_V11_cfg.py (with these additional lines

from L1Trigger.L1THGCal.customTriggerGeometry import custom_geometry_decentralized_V11
process = custom_geometry_decentralized_V11(process, links='signaldriven', implementation=2)

in order to use the latest geometry) it seems to produce an empty cluster collection.
I tracked this down to the geometry getStage2FpgasFromStage1Fpga which seems to return empty sets.
Do you see the same?

[snwebb]

Yes sorry there's a bug there in the geometry shall I fix it here, or would you like a new request?

[jbsauvan]

Yes sorry there's a bug there in the geometry shall I fix it here, or would you like a new request?

Probably better to fix it here

[snwebb]

thanks, done.

[jbsauvan]

Thanks @snwebb, there are now output clusters.
But I see some holes in the cluster phi distribution, which I wouldn't expect, as if there was no overlap between Stage 2 regions:

Do you have an idea where it could come from?

[snwebb]

thanks @jbsauvan - there were a couple of bugs, which are hopefully now fixed.

[jbsauvan]

Thanks @snwebb
The distributions look fine now. There are regions with an excess of clusters, but this is expected as there is no overlap removal in Stage 2 regions at the moment.