New backend stage 1 producer/processor #500

portalesHEP · 2021-10-19T07:38:43Z

Added new stage 1 producer (HGCalBackendStage1Producer.cc) and processor (HGCalBackendStage1Processor.cc) defined so that the processor only handles the information from a single FPGA.

The previous producer/processor pair is kept for now, but renamed HGCalBackendLayer1Producer.cc/HGCalBackendLayer1Producer.cc following the older naming convention.

…ucer/processor

jbsauvan

Thanks @portalesHEP
in addition to the comments below, an update will be needed on the trigger chains:
In L1Trigger/L1THGCalUtilities/python/clustering2d.py there is currently the functor RozBinTruncation that is used to create a Producer with tuncation. This will require some modification.

L1Trigger/L1THGCal/plugins/HGCalBackendStage1Producer.cc

L1Trigger/L1THGCal/python/customNewProcessors.py

L1Trigger/L1THGCal/python/hgcalBackEndLayer2Producer_cfi.py

L1Trigger/L1THGCalUtilities/test/testHGCalL1T_RelValV11_cfg.py

portalesHEP · 2021-10-26T12:58:50Z

Thanks @portalesHEP in addition to the comments below, an update will be needed on the trigger chains: In L1Trigger/L1THGCalUtilities/python/clustering2d.py there is currently the functor RozBinTruncation that is used to create a Producer with tuncation. This will require some modification.

This is now (mostly) done in commit e6047a.

It is done by adding a new RozBinTruncation definition in clustering2d_v2.py that calls the correct stage1 producer. In order to use it to produce ntuples, hgcalTriggerPrimitivesNew_cff has to be loaded instead of hgcalTriggerPrimitives_cff.

I still need to include some adaptation of the CreateDummy class, as right now truncation is applied by default with it in the new setup.

jbsauvan

Thanks @portalesHEP
In addition to the proposed removals in clustering2d_v2.py, could you run and apply the changes of code-checks and code-format?

jbsauvan · 2021-11-02T11:02:46Z

L1Trigger/L1THGCalUtilities/python/clustering2d_v2.py

+def create_distance(process, inputs,
+                    distance=distance_C2d_params.dR_cluster,  # cm
+                    seed_threshold=distance_C2d_params.seeding_threshold_silicon,  # MipT
+                    cluster_threshold=distance_C2d_params.clustering_threshold_silicon  # MipT
+                    ):
+    producer = process.hgcalBackEndStage1Producer.clone(
+            InputTriggerCells = cms.InputTag(inputs)
+            )
+    producer.ProcessorParameters.C2d_parameters = distance_C2d_params.clone(
+            dR_cluster = distance
+            )
+    set_threshold_params(producer.ProcessorParameters.C2d_parameters, seed_threshold, cluster_threshold)
+    return producer
+
+
+def create_topological(process, inputs,
+                       seed_threshold=topological_C2d_params.seeding_threshold_silicon,  # MipT
+                       cluster_threshold=topological_C2d_params.clustering_threshold_silicon  # MipT
+                       ):
+    producer = process.hgcalBackEndStage1Producer.clone(
+            InputTriggerCells = cms.InputTag(inputs)
+            )
+    producer.ProcessorParameters.C2d_parameters = topological_C2d_params.clone()
+    set_threshold_params(producer.ProcessorParameters.C2d_parameters, seed_threshold, cluster_threshold)
+    return producer
+
+
+def create_constrainedtopological(process, inputs,
+                                  distance=constrTopological_C2d_params.dR_cluster,  # cm
+                                  seed_threshold=constrTopological_C2d_params.seeding_threshold_silicon,  # MipT
+                                  cluster_threshold=constrTopological_C2d_params.clustering_threshold_silicon  # MipT
+                                  ):
+    producer = process.hgcalBackEndStage1Producer.clone(
+            InputTriggerCells = cms.InputTag(inputs)
+            )
+    producer.ProcessorParameters.C2d_parameters = constrTopological_C2d_params.clone(
+            dR_cluster = distance
+            )
+    set_threshold_params(producer.ProcessorParameters.C2d_parameters, seed_threshold, cluster_threshold)
+    return producer


These functions should probably be removed (as well as the related imports) as these clustering algos are not supposed to be used with the new Stage 1 producer

Indeed, I removed them

jbsauvan · 2021-11-02T11:04:40Z

L1Trigger/L1THGCalUtilities/python/clustering2d_v2.py

+        producer = process.hgcalBackEndStage1Producer.clone(
+                InputTriggerCells = cms.InputTag(inputs)
+                )
+        producer.ProcessorParameters.C2d_parameters = dummy_C2d_params.clone()


C2d_parameters is a parameter of the producer and not of the processor in the case of hgcalBackEndStage1Producer.
Actually, I'm not sure that we need this CreateDummy at all, since a "dummy" stage1Producer would be created from RozBinTruncation with doTruncation=False

jbsauvan · 2021-11-02T11:05:57Z

L1Trigger/L1THGCalUtilities/python/clustering2d_v2.py

+class CreateTruthDummy(object):
+    def __call__(self, process, inputs):
+        producer = process.hgcalBackEndStage1Producer.clone(
+                InputTriggerCells = cms.InputTag(inputs)
+                )
+        producer.ProcessorParameters.C2d_parameters = dummy_C2d_params.clone()
+        return producer


Should probably be removed. It will probably not work like that.

portalesHEP · 2021-11-02T13:46:08Z

Thanks @portalesHEP In addition to the proposed removals in clustering2d_v2.py, could you run and apply the changes of code-checks and code-format?

This is now done too

L1Trigger/L1THGCalUtilities/python/clustering2d_v2.py

portalesHEP added 7 commits October 18, 2021 16:36

initial commit

66ef0a2

better naming + re-including previous s1 processing in separated prod…

4469907

…ucer/processor

custom processor & ntuples to match new s1 definition + some cleaning

4b49ade

minor fixes

de29ac1

some cleaning

85b1d86

minor fix

d06e4a4

fixed custom truncation with older config

10eb9a2

jbsauvan added this to Review in HGC L1 Simulation and Algorithms Oct 25, 2021

jbsauvan reviewed Oct 25, 2021

View reviewed changes

portalesHEP added 2 commits October 25, 2021 12:37

Starting implementation of comments

61da2fa

trigger chain adaptation

e60407a

portalesHEP added 2 commits October 26, 2021 15:00

removing unnecessary file

8aee6be

adding flag to truncation implementation to run without trunctation

7055dda

jbsauvan reviewed Nov 2, 2021

View reviewed changes

portalesHEP added 3 commits November 2, 2021 14:04

clustering2d_v2.py: removing non-useful definitions

a9a29c3

correction from code-checks

4df6c26

add changes from code-format

a73e921

jbsauvan reviewed Nov 2, 2021

View reviewed changes

L1Trigger/L1THGCalUtilities/python/clustering2d_v2.py Outdated Show resolved Hide resolved

removing unuseed imports

9c44f40

jbsauvan merged commit 2337244 into PFCal-dev:hgc-tpg-devel-CMSSW_12_0_0_pre3 Nov 2, 2021

jbsauvan moved this from Review to Ready for Integration in HGC L1 Simulation and Algorithms Nov 2, 2021

jbsauvan mentioned this pull request Nov 2, 2021

[Backport 11_3_0] New backend stage 1 producer/processor #505

Merged

portalesHEP deleted the s1_standalone branch November 5, 2021 09:54

jbsauvan moved this from Ready for Integration to Integration In Progress in HGC L1 Simulation and Algorithms Dec 2, 2021

This was referenced Dec 2, 2021

[HGCAL trigger] Migration to new code structure - First pass cms-sw/cmssw#36337

Merged

Integration new code structure - part 1 hgc-tpg/cmssw#3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New backend stage 1 producer/processor #500

New backend stage 1 producer/processor #500

portalesHEP commented Oct 19, 2021

jbsauvan left a comment

portalesHEP commented Oct 26, 2021 •

edited

jbsauvan left a comment

jbsauvan Nov 2, 2021

portalesHEP Nov 2, 2021

jbsauvan Nov 2, 2021

portalesHEP Nov 2, 2021

jbsauvan Nov 2, 2021

portalesHEP Nov 2, 2021

portalesHEP commented Nov 2, 2021

New backend stage 1 producer/processor #500

New backend stage 1 producer/processor #500

Conversation

portalesHEP commented Oct 19, 2021

jbsauvan left a comment

Choose a reason for hiding this comment

portalesHEP commented Oct 26, 2021 • edited

jbsauvan left a comment

Choose a reason for hiding this comment

jbsauvan Nov 2, 2021

Choose a reason for hiding this comment

portalesHEP Nov 2, 2021

Choose a reason for hiding this comment

jbsauvan Nov 2, 2021

Choose a reason for hiding this comment

portalesHEP Nov 2, 2021

Choose a reason for hiding this comment

jbsauvan Nov 2, 2021

Choose a reason for hiding this comment

portalesHEP Nov 2, 2021

Choose a reason for hiding this comment

portalesHEP commented Nov 2, 2021

portalesHEP commented Oct 26, 2021 •

edited