Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with Kong 0.8.0 because tagline in that version is 'kong' lowercase #38

Closed
chrisfarnham opened this issue Apr 15, 2016 · 4 comments

Comments

@chrisfarnham
Copy link

Spun up the new Kong 0.8.0 to kick the tires. Couldn't get dashboard to recognize the node as a node. Quick review of the code tells me that it's trying to match the 'tagline' attribute returned a GET to the admin panel but can't because the case of Kong in the tagline has been changed.

Recommend a less brittle way of assessing if is, in fact, a Kong node.

@jfirehammer-credibly
Copy link
Contributor

I just hit this too. Are they any other 0.8.0 issues you have hit?

@chrisfarnham
Copy link
Author

I patched my local source and have been using it with no problems other
than the one i reported.

Christopher Farnham
chris.farnham@gmail.com

On Fri, Apr 15, 2016 at 2:36 PM, jfirehammer-credibly <
notifications@github.com> wrote:

I just hit this too. Are they any other 0.8.0 issues you have hit?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#38 (comment)

@jimmytoan
Copy link

How to patch it @chrisfarnham

@PGBI
Copy link
Owner

PGBI commented Apr 19, 2016

Fixed on version 1.1.2. Thanks @chrisfarnham for reporting this.

@PGBI PGBI closed this as completed Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants