Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fix #81

Merged
merged 4 commits into from
Mar 10, 2017
Merged

Docker fix #81

merged 4 commits into from
Mar 10, 2017

Conversation

jfirehammer-credibly
Copy link
Contributor

The docker build failed as of today and the latest alpine release.
I made a best effort guess as to when the last build worked and rev-locked it.
Feel free to change the rev as needed if it's not what you want.

@PGBI
Copy link
Owner

PGBI commented Mar 9, 2017

On my side, I don't have any difficulty to build the docker image from the current master branch. What error do you get?

@jfirehammer-credibly
Copy link
Contributor Author

jfirehammer-credibly commented Mar 9, 2017

So, there are a number of errors, but it starts with this and they cascade from it:

Cannot download "https://github.com/sass/node-sass/releases/download/v4.5.0/linux_musl-x64-47_binding.node": 

HTTP error 404 Not Found       

I am pretty sure it has to do with the 'latest' version of alpine on my production machine being an older version that was locally cached. (I just reproduced it again now). So my first comment was wrong, it's actually the other way around. The actual latest works. That's why it does not fail for you, and also does not fail for me on a different machine that had not yet downloaded alpine yet.

This is why I've found that it's always good to rev lock your dockerfiles. (I run all of my servers in docker and have run into this enough times that I always do it now!)

@PGBI
Copy link
Owner

PGBI commented Mar 9, 2017

I agree with you that rev-locking is a good practise. But I'd like to be able to reproduce the error. I completely removed all containers and images from my docker setup, and rebuild kong-dashboard image from scratch. It succeeded.

Also, on docker hub, a kong-dashboard image was built from the master branch 4 hours ago, without no problem. See the logs section on this page => https://hub.docker.com/r/pgbi/kong-dashboard/builds/bvwxpk2kqqpwcxddpbnanuh/

@jfirehammer-credibly
Copy link
Contributor Author

Yes, it will succeed because if you remove all images, it will download the latest alpine which works fine. The problem is if, as in my case, the last time I built using alpine was awhile ago, the 'latest' on my machine is not the actual latest version. For example:

> docker images
mhart/alpine-node                     7.5.0               2f72775ebfff        5 weeks ago         53.47 MB
mhart/alpine-node                     latest              a5ba4d8acdbc        11 months ago       36.83 MB

>  sudo docker run mhart/alpine-node node --version
v5.10.1

So you can't reproduce the issue using your current dockerfile, but you can fake it by setting it to my version, e.g.

FROM mhart/alpine-node:5.10.1

I just reproduced it that way myself on my newer machine.

Also FYI it appears that the latest as of right now is 7.7.2.

@PGBI
Copy link
Owner

PGBI commented Mar 10, 2017

Ok makes sense. I initially understood that all build were failing past a certain alpine version. Thanks for the explanation and the PR!

@PGBI PGBI merged commit d36c028 into PGBI:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants