-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker fix #81
Docker fix #81
Conversation
…PGBI-master Conflicts: src/js/services/kong.js
On my side, I don't have any difficulty to build the docker image from the current master branch. What error do you get? |
So, there are a number of errors, but it starts with this and they cascade from it:
I am pretty sure it has to do with the 'latest' version of alpine on my production machine being an older version that was locally cached. (I just reproduced it again now). So my first comment was wrong, it's actually the other way around. The actual latest works. That's why it does not fail for you, and also does not fail for me on a different machine that had not yet downloaded alpine yet. This is why I've found that it's always good to rev lock your dockerfiles. (I run all of my servers in docker and have run into this enough times that I always do it now!) |
I agree with you that rev-locking is a good practise. But I'd like to be able to reproduce the error. I completely removed all containers and images from my docker setup, and rebuild kong-dashboard image from scratch. It succeeded. Also, on docker hub, a kong-dashboard image was built from the master branch 4 hours ago, without no problem. See the logs section on this page => https://hub.docker.com/r/pgbi/kong-dashboard/builds/bvwxpk2kqqpwcxddpbnanuh/ |
Yes, it will succeed because if you remove all images, it will download the latest alpine which works fine. The problem is if, as in my case, the last time I built using alpine was awhile ago, the 'latest' on my machine is not the actual latest version. For example:
So you can't reproduce the issue using your current dockerfile, but you can fake it by setting it to my version, e.g.
I just reproduced it that way myself on my newer machine. Also FYI it appears that the latest as of right now is 7.7.2. |
Ok makes sense. I initially understood that all build were failing past a certain alpine version. Thanks for the explanation and the PR! |
The docker build failed as of today and the latest alpine release.
I made a best effort guess as to when the last build worked and rev-locked it.
Feel free to change the rev as needed if it's not what you want.