Add support for upgrade_adapt.sql in cross-version upgrade tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL upstream commit 0df9641d has moved from pg_upgrade's test.sh to a SQL file the set of SQL commands that are used to clean up a cluster to-be-upgraded to the latest version on the branch where the script is located. Moving to this script in the buildfarm code has two advantages: 1) It makes possible the deletion of some of the buildfarm client code that was previously duplicated with pg_upgrade/test.sh for the same cleanup. 2) Upstream committers could push changes directly to the new SQL file pg_upgrade/upgrade_adapt.sql to do any object manipulation in the main "regression" database, so as there is no need to change the buildfarm code at all. Nothing is done for the contrib/ modules, and upstream does not have any test coverage for these with pg_upgrade, contrary to the buildfarm. Hence, the code cleaned up relates to the database "regression", on which the main regression suite is run in the case of Postgres. Note: I think that the code is correct as it stands, including the fact that $self in test_upgrade() refers to the node on the newer version, but I have not been able to directly test it with a buildfarm animal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL upstream commit 0df9641d has moved from pg_upgrade's test.sh
to a SQL file the set of SQL commands that are used to clean up a
cluster to-be-upgraded to the latest version on the branch where the
script is located.
Moving to this script in the buildfarm code has two advantages:
that was previously duplicated with pg_upgrade/test.sh for the same
cleanup.
pg_upgrade/upgrade_adapt.sql to do any object manipulation in the main
"regression" database, so as there is no need to change the buildfarm
code at all.
Nothing is done for the contrib/ modules, and upstream does not have any
test coverage for these with pg_upgrade, contrary to the buildfarm.
Hence, the code cleaned up relates to the database "regression", on
which the main regression suite is run in the case of Postgres.
Note: I think that the code is correct as it stands, including the fact
that $self in test_upgrade() refers to the node on the newer version,
but I have not been able to directly test it with a buildfarm animal.