Update dependencies and fix text translations test #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BT (calcastor/mame) <43831917+calcastor@users.noreply.github.com>
calcastor
force-pushed
the
dep-updates
branch
2 times, most recently
from
48d9836
to
2d13a60
Compare
Signed-off-by: BT (calcastor/mame) <43831917+calcastor@users.noreply.github.com>
calcastor
changed the title
Electroid
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, this PR updates all dependencies that are possible or reasonable to update (not sure what that old log4j is there for). Briefly tested a running server and everything seems to work as intended.
If we introduce a build-time dependency on JDK 11 or above, we can upgrade
fmt-maven-pluginto the latest version now maintained by Spotify, but I don't know if we want to do that. For the record, I haven't built PGM with a JDK lower than 11 in ages and it always seems to run fine. Given that, and sincefmt-maven-pluginis only used when building to check code style, such a dependency might be reasonable, but I would understand hesistancy.What we cannot update is JGit, newer versions of which depend on a Java 11+ runtime.
Secondly, this PR fixes
TextTranslationsTest. For some reason our tests seem to have just not been running at all, at least until CI images received an update to Maven 3.9.0. They suddenly work now, somehow.testGetLocalesseems to assume a different enough locale fromUSwill always be available, so let's runtestGetNearestLocalefirst and then check for eitherlocales.contains(Locale.getDefault())orlocales.contains(getNearestLocale(Locale.getDefault()))intestGetLocales.