Potential bug with annotation trait URI : Ischemic stroke

[spiros]

The PGS traits dataset (pgs_traits_data.csv) entry for ischemic stroke (http://purl.obolibrary.org/obo/HP_0002140) is, I think, malformed and contains

The current value is "https://www.ebi.ac.uk/ols/ontologies/efo/terms?iri=http://purl.obolibrary.org/obo/HP_0002140"

Whereas it should be "http://purl.obolibrary.org/obo/HP_0002140"

[smlmbrt]

Thanks for your comment @spiros, this will get corrected in the next release!

I think we originally had all of the external IDs like this so that they would link back to the copy of the term in the Experimental Factor Ontology (EFO) where we source the term definition and parent/child linkages. I wonder if we should consider adding a separate EFO URL field to capture this?

[spiros]

Hm good question, not sure what the best approach is - I've seen it both ways i.e. sometimes the EFO_URL contains non-EFO URIs in there, and sometimes they are separated...!

…

On Wed, Nov 30, 2022 at 12:57 PM Sam Lambert ***@***.***> wrote: Thanks for your comment @spiros <https://github.com/spiros>, this will get corrected in the next release! I think we originally had all of the external IDs like this so that they would link back to the copy of the term in the Experimental Factor Ontology (EFO) where we source the term definition and parent/child linkages. I wonder if we should consider adding a separate EFO URL field to capture this? — Reply to this email directly, view it on GitHub <#249 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFZZHN46S5JM3XNA6RZG3WK46IZANCNFSM6AAAAAASPMYWGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[smlmbrt]

#250 corrected the URL so it should be the purl ID in the current and all future releases.