Load balancer #807
Load balancer #807
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... Files selected for processing (43)
WalkthroughThe update brings significant enhancements to the PyPHARE project, introducing new functionalities and optimizations across various modules. Key changes include integrating load balancing strategies, improving logging and diagnostics, and adding new simulation tests. These modifications enhance project robustness, performance, and flexibility, particularly in handling adaptive mesh refinement (AMR) and floating-point precision comparisons. The updates extend the project's capabilities by supporting both C and C++ languages. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
aa39144
to
c42b4cd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_homogeneous.hpp
Fixed
Show fixed
Hide fixed
src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_homogeneous.hpp
Fixed
Show fixed
Hide fixed
src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_nppc.hpp
Outdated
Show resolved
Hide resolved
src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_homogeneous.hpp
Outdated
Show resolved
Hide resolved
src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_homogeneous.hpp
Outdated
Show resolved
Hide resolved
src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_nppc.hpp
Outdated
Show resolved
Hide resolved
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
c42b4cd
to
b8c6324
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
680df48
to
c80b8b0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
7def490
to
8fd1512
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
8fd1512
to
d301826
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
d5ab1f4
to
ff5f74a
Compare
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
ff5f74a
to
dd0fe18
Compare
There was a problem hiding this comment.
Actionable comments posted: 11
Out of diff range and nitpick comments (6)
res/cmake/dep/caliper.cmake (1)
5-6: Consider adding more detailed documentation or examples on how to use the new Caliper configuration for inclusive timings per function. This will help users understand when and why they might want to use this configuration.pyphare/pyphare/pharein/load_balancer.py (1)
11-20: Ensure that the default values for theLoadBalancerproperties are well-documented, especially how they interact with each other (e.g., howautoaffects the use ofon_initandevery).pyphare/pyphare/simulator/simulator.py (2)
Line range hint
99-99: Avoid using bareexceptstatements as they can mask unexpected errors. Specify the exceptions you expect to handle.- except: + except Exception as e: + # Handle specific exceptions here
Line range hint
119-119: Avoid using bareexceptstatements as they can mask unexpected errors. Specify the exceptions you expect to handle.- except: + except Exception as e: + # Handle specific exceptions heresrc/amr/wrappers/integrator.hpp (2)
4-4: Consider organizing imports to group related headers together for better readability.
62-64: The constructor now initializes several new member variables related to load balancing. Ensure these are properly documented to clarify their roles.
src/amr/wrappers/integrator.hpp
Outdated
| bool _should_rebalance_now(); | ||
|
|
||
| bool cadence_rebalance_check() | ||
| { | ||
| return (time_step_idx == 0 and lb_info_.on_init) | ||
| or (lb_info_.every > 0 and time_step_idx > 0 | ||
| and time_step_idx % lb_info_.every == 0); | ||
| } | ||
|
|
||
| bool tolerance_rebalance_check() | ||
| { | ||
| std::size_t constexpr static next_rebalance_backoff_multiplier = 2; | ||
| std::size_t constexpr static next_rebalance_defaut = 200; | ||
| std::size_t constexpr static max_next_rebalance = 1000; | ||
|
|
||
| if (rebalance_coarsest_auto_back_off == 0) | ||
| { | ||
| PHARE_LOG_SCOPE(1, "Integrator::_should_rebalance_now::automatic"); | ||
|
|
||
| auto workLoads = core::mpi::collect(computeNonUniformWorkLoadForLevel0()); | ||
| auto const max_value = *std::max_element(workLoads.begin(), workLoads.end()); | ||
| for (auto& workload : workLoads) | ||
| workload /= max_value; | ||
| auto const min_value = *std::min_element(workLoads.begin(), workLoads.end()); | ||
| assert(min_value <= 1); | ||
|
|
||
| if ((1 - min_value) > lb_info_.tolerance) | ||
| { | ||
| rebalance_coarsest_auto_back_off_by = next_rebalance_defaut; | ||
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | ||
| return true; | ||
| } | ||
|
|
||
| rebalance_coarsest_auto_back_off_by *= next_rebalance_backoff_multiplier; | ||
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | ||
|
|
||
| if (rebalance_coarsest_auto_back_off > max_next_rebalance) | ||
| rebalance_coarsest_auto_back_off_by = rebalance_coarsest_auto_back_off | ||
| = max_next_rebalance; | ||
| } | ||
|
|
||
| --rebalance_coarsest_auto_back_off; | ||
| return false; | ||
| }; |
There was a problem hiding this comment.
The method _should_rebalance_now contains complex logic with multiple conditional checks and mathematical operations. Consider refactoring this method to improve readability and maintainability.
- bool _should_rebalance_now();
+ bool _should_rebalance_now(); // Consider refactoring for simplicityCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| bool _should_rebalance_now(); | |
| bool cadence_rebalance_check() | |
| { | |
| return (time_step_idx == 0 and lb_info_.on_init) | |
| or (lb_info_.every > 0 and time_step_idx > 0 | |
| and time_step_idx % lb_info_.every == 0); | |
| } | |
| bool tolerance_rebalance_check() | |
| { | |
| std::size_t constexpr static next_rebalance_backoff_multiplier = 2; | |
| std::size_t constexpr static next_rebalance_defaut = 200; | |
| std::size_t constexpr static max_next_rebalance = 1000; | |
| if (rebalance_coarsest_auto_back_off == 0) | |
| { | |
| PHARE_LOG_SCOPE(1, "Integrator::_should_rebalance_now::automatic"); | |
| auto workLoads = core::mpi::collect(computeNonUniformWorkLoadForLevel0()); | |
| auto const max_value = *std::max_element(workLoads.begin(), workLoads.end()); | |
| for (auto& workload : workLoads) | |
| workload /= max_value; | |
| auto const min_value = *std::min_element(workLoads.begin(), workLoads.end()); | |
| assert(min_value <= 1); | |
| if ((1 - min_value) > lb_info_.tolerance) | |
| { | |
| rebalance_coarsest_auto_back_off_by = next_rebalance_defaut; | |
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | |
| return true; | |
| } | |
| rebalance_coarsest_auto_back_off_by *= next_rebalance_backoff_multiplier; | |
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | |
| if (rebalance_coarsest_auto_back_off > max_next_rebalance) | |
| rebalance_coarsest_auto_back_off_by = rebalance_coarsest_auto_back_off | |
| = max_next_rebalance; | |
| } | |
| --rebalance_coarsest_auto_back_off; | |
| return false; | |
| }; | |
| bool _should_rebalance_now(); // Consider refactoring for simplicity | |
| bool cadence_rebalance_check() | |
| { | |
| return (time_step_idx == 0 and lb_info_.on_init) | |
| or (lb_info_.every > 0 and time_step_idx > 0 | |
| and time_step_idx % lb_info_.every == 0); | |
| } | |
| bool tolerance_rebalance_check() | |
| { | |
| std::size_t constexpr static next_rebalance_backoff_multiplier = 2; | |
| std::size_t constexpr static next_rebalance_defaut = 200; | |
| std::size_t constexpr static max_next_rebalance = 1000; | |
| if (rebalance_coarsest_auto_back_off == 0) | |
| { | |
| PHARE_LOG_SCOPE(1, "Integrator::_should_rebalance_now::automatic"); | |
| auto workLoads = core::mpi::collect(computeNonUniformWorkLoadForLevel0()); | |
| auto const max_value = *std::max_element(workLoads.begin(), workLoads.end()); | |
| for (auto& workload : workLoads) | |
| workload /= max_value; | |
| auto const min_value = *std::min_element(workLoads.begin(), workLoads.end()); | |
| assert(min_value <= 1); | |
| if ((1 - min_value) > lb_info_.tolerance) | |
| { | |
| rebalance_coarsest_auto_back_off_by = next_rebalance_defaut; | |
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | |
| return true; | |
| } | |
| rebalance_coarsest_auto_back_off_by *= next_rebalance_backoff_multiplier; | |
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | |
| if (rebalance_coarsest_auto_back_off > max_next_rebalance) | |
| rebalance_coarsest_auto_back_off_by = rebalance_coarsest_auto_back_off | |
| = max_next_rebalance; | |
| } | |
| --rebalance_coarsest_auto_back_off; | |
| return false; | |
| }; |
pyphare/pyphare/pharesee/run.py
Outdated
| def GetAllAvailableQties(self, time=0, pops=[]): | ||
| assert self.single_hier_for_all_quantities # can't work otherwise | ||
|
|
||
| self.GetParticles(time, pops) | ||
| self.GetB(time) | ||
| self.GetE(time) | ||
| self.GetNi(time) | ||
| self.GetVi(time) | ||
| def _try(fn, *args, **kwargs): | ||
| try: | ||
| fn(*args, **kwargs) | ||
| except Exception: | ||
| ... # file not found | ||
|
|
||
| _try(self.GetParticles, time, pops) | ||
| _try(self.GetB, time) | ||
| _try(self.GetE, time) | ||
| _try(self.GetNi, time) | ||
| _try(self.GetVi, time) | ||
|
|
||
| for pop in pops: | ||
| self.GetFlux(time, pop) | ||
| self.GetN(time, pop) | ||
| _try(self.GetFlux, time, pop) | ||
| _try(self.GetN, time, pop) |
There was a problem hiding this comment.
Replace the ellipsis in the exception handling block with proper logging.
- ... # file not found
+ log.error("File not found", exc_info=True) # Log the exception informationCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| def GetAllAvailableQties(self, time=0, pops=[]): | |
| assert self.single_hier_for_all_quantities # can't work otherwise | |
| self.GetParticles(time, pops) | |
| self.GetB(time) | |
| self.GetE(time) | |
| self.GetNi(time) | |
| self.GetVi(time) | |
| def _try(fn, *args, **kwargs): | |
| try: | |
| fn(*args, **kwargs) | |
| except Exception: | |
| ... # file not found | |
| _try(self.GetParticles, time, pops) | |
| _try(self.GetB, time) | |
| _try(self.GetE, time) | |
| _try(self.GetNi, time) | |
| _try(self.GetVi, time) | |
| for pop in pops: | |
| self.GetFlux(time, pop) | |
| self.GetN(time, pop) | |
| _try(self.GetFlux, time, pop) | |
| _try(self.GetN, time, pop) | |
| def GetAllAvailableQties(self, time=0, pops=[]): | |
| assert self.single_hier_for_all_quantities # can't work otherwise | |
| def _try(fn, *args, **kwargs): | |
| try: | |
| fn(*args, **kwargs) | |
| except Exception: | |
| log.error("File not found", exc_info=True) # Log the exception information | |
| _try(self.GetParticles, time, pops) | |
| _try(self.GetB, time) | |
| _try(self.GetE, time) | |
| _try(self.GetNi, time) | |
| _try(self.GetVi, time) | |
| for pop in pops: | |
| _try(self.GetFlux, time, pop) | |
| _try(self.GetN, time, pop) |
pyphare/pyphare/pharesee/run.py
Outdated
| def GetAllAvailableQties(self, time, pops): | ||
| assert self.single_hier_for_all_quantities == True # can't work otherwise | ||
| def GetAllAvailableQties(self, time=0, pops=[]): | ||
| assert self.single_hier_for_all_quantities # can't work otherwise |
There was a problem hiding this comment.
Consider replacing the assert statement with a more robust control flow mechanism.
Assert statements are generally used for debugging purposes and not for controlling program flow. Consider using an if statement and raising an appropriate exception if the condition is not met.
| if self.mode not in allowed_modes: | ||
| raise RuntimeError(f"LoadBalancer mode '{self.mode}' is not valid") | ||
|
|
There was a problem hiding this comment.
The error message should include all allowed modes to guide the user correctly. This change was suggested in a previous review and should be implemented to enhance usability.
- raise RuntimeError(f"LoadBalancer mode '{self.mode}' is not valid")
+ raise RuntimeError(f"LoadBalancer mode '{self.mode}' is not valid. Allowed modes are: {allowed_modes}")Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if self.mode not in allowed_modes: | |
| raise RuntimeError(f"LoadBalancer mode '{self.mode}' is not valid") | |
| if self.mode not in allowed_modes: | |
| raise RuntimeError(f"LoadBalancer mode '{self.mode}' is not valid. Allowed modes are: {allowed_modes}") |
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
dd0fe18
to
a8dc16a
Compare
PhilipDeegan
force-pushed
the
loadBalancer
branch
2 times, most recently
from
c1cef36
to
c911d4d
Compare
PhilipDeegan
force-pushed
the
loadBalancer
branch
2 times, most recently
from
749286a
to
d24d498
Compare
There was a problem hiding this comment.
Actionable comments posted: 28
Out of diff range and nitpick comments (10)
tests/diagnostic/__init__.py (1)
Line range hint
16-16: Remove the unused import ofnumpy.- import pyphare.pharein as ph, numpy as np + import pyphare.pharein as phpyphare/pyphare/simulator/simulator.py (3)
Line range hint
110-110: Avoid using bareexceptstatements. Specify the exception types to catch.- except: + except Exception:
Line range hint
133-133: Avoid using bareexceptstatements. Specify the exception types to catch.- except: + except Exception:
Line range hint
164-164: Useis not Nonefor comparison to follow Python best practices.- if self._auto_dump() and self.post_advance != None: + if self._auto_dump() and self.post_advance is not None:pyphare/pyphare/pharein/maxwellian_fluid_model.py (1)
Line range hint
4-4: Remove the unused importyee_element_is_primalto clean up the code.- from pyphare.core.gridlayout import GridLayout, yee_element_is_primal + from pyphare.core.gridlayout import GridLayouttests/simulator/__init__.py (3)
Line range hint
77-77: Avoid assigning alambdaexpression directly to a variable. Use adefstatement instead for better readability and debugging.- _ = lambda i: 0.1 * np.cos(2 * np.pi * xyz[i] / L[i]) + def _(i): + return 0.1 * np.cos(2 * np.pi * xyz[i] / L[i])
Line range hint
178-178: TheBoxclass is used but not defined or imported. Ensure thatBoxis defined or imported correctly.+ from some_module import BoxAlso applies to: 184-184, 191-191
Line range hint
77-77: Thetime_step_nbrparameter is no longer used and should be removed if it's not required for backward compatibility or other reasons.- "time_step_nbr": 1000,pyphare/pyphare/pharein/__init__.py (1)
Line range hint
32-47: Move all import statements to the top of the file and remove unused imports to follow Python's best practices.- from .uniform_model import UniformModel - from .maxwellian_fluid_model import MaxwellianFluidModel - from .electron_model import ElectronModel - from .diagnostics import ( - FluidDiagnostics, - ElectromagDiagnostics, - ParticleDiagnostics, - MetaDiagnostics, - InfoDiagnostics, - ) - from .simulation import ( - Simulation, - serialize as serialize_sim, - deserialize as deserialize_sim, - ) - from .load_balancer import LoadBalancer + # Move all imports to the top of the file + from .uniform_model import UniformModel + from .maxwellian_fluid_model import MaxwellianFluidModel + from .electron_model import ElectronModel + from .diagnostics import ( + FluidDiagnostics, + ElectromagDiagnostics, + ParticleDiagnostics, + MetaDiagnostics, + InfoDiagnostics, + ) + from .simulation import ( + Simulation, + serialize as serialize_sim, + deserialize as deserialize_sim, + ) + from .load_balancer import LoadBalancerpyphare/pyphare/pharein/simulation.py (1)
630-630: Update documentation to includeloadbalancing.The
wrapperfunction now acceptsloadbalancingas a keyword. Consider updating the documentation to reflect this change and provide examples of how to use this new option.
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (41)
- pyphare/pyphare/pharein/init.py (5 hunks)
- pyphare/pyphare/pharein/load_balancer.py (1 hunks)
- pyphare/pyphare/pharein/maxwellian_fluid_model.py (2 hunks)
- pyphare/pyphare/pharein/simulation.py (7 hunks)
- pyphare/pyphare/pharesee/hierarchy.py (6 hunks)
- pyphare/pyphare/pharesee/particles.py (1 hunks)
- pyphare/pyphare/simulator/simulator.py (5 hunks)
- pyphare/pyphare_tests/test_pharesee/test_geometry_3d.py (1 hunks)
- res/cmake/def.cmake (4 hunks)
- res/cmake/dep/samrai.cmake (1 hunks)
- src/amr/CMakeLists.txt (2 hunks)
- src/amr/data/particles/particles_data.hpp (1 hunks)
- src/amr/level_initializer/hybrid_level_initializer.hpp (2 hunks)
- src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_homogeneous.hpp (1 hunks)
- src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_nppc.hpp (1 hunks)
- src/amr/load_balancing/load_balancer_details.hpp (1 hunks)
- src/amr/load_balancing/load_balancer_estimator.hpp (1 hunks)
- src/amr/load_balancing/load_balancer_estimator_hybrid.hpp (1 hunks)
- src/amr/load_balancing/load_balancer_hybrid_strategy.hpp (1 hunks)
- src/amr/load_balancing/load_balancer_hybrid_strategy_factory.hpp (1 hunks)
- src/amr/load_balancing/load_balancer_manager.hpp (1 hunks)
- src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp (11 hunks)
- src/amr/multiphysics_integrator.hpp (13 hunks)
- src/amr/wrappers/integrator.hpp (4 hunks)
- src/core/data/ions/particle_initializers/maxwellian_particle_initializer.hpp (6 hunks)
- src/core/data/ions/particle_initializers/particle_initializer_factory.hpp (2 hunks)
- src/core/data/ndarray/ndarray_vector.hpp (1 hunks)
- src/core/data/particles/particle_array.hpp (1 hunks)
- src/core/utilities/box/box.hpp (1 hunks)
- src/initializer/data_provider.hpp (1 hunks)
- src/initializer/dictator.cpp (1 hunks)
- src/simulator/simulator.hpp (6 hunks)
- tests/core/data/ions/test_ions.cpp (1 hunks)
- tests/diagnostic/init.py (1 hunks)
- tests/functional/harris/harris_2d_lb.py (1 hunks)
- tests/simulator/CMakeLists.txt (1 hunks)
- tests/simulator/init.py (2 hunks)
- tests/simulator/test_load_balancing.py (1 hunks)
- tests/simulator/test_tagging.py.off (1 hunks)
- tools/python3/init.py (2 hunks)
- tools/python3/caliper.py (1 hunks)
Files not reviewed due to errors (1)
- pyphare/pyphare/pharesee/particles.py (no review received)
Files skipped from review as they are similar to previous changes (24)
- res/cmake/def.cmake
- res/cmake/dep/samrai.cmake
- src/amr/CMakeLists.txt
- src/amr/data/particles/particles_data.hpp
- src/amr/level_initializer/hybrid_level_initializer.hpp
- src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_homogeneous.hpp
- src/amr/load_balancing/concrete_load_balancer_hybrid_strategy_nppc.hpp
- src/amr/load_balancing/load_balancer_details.hpp
- src/amr/load_balancing/load_balancer_estimator.hpp
- src/amr/load_balancing/load_balancer_estimator_hybrid.hpp
- src/amr/load_balancing/load_balancer_hybrid_strategy.hpp
- src/amr/load_balancing/load_balancer_hybrid_strategy_factory.hpp
- src/amr/load_balancing/load_balancer_manager.hpp
- src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp
- src/core/data/ions/particle_initializers/maxwellian_particle_initializer.hpp
- src/core/data/ions/particle_initializers/particle_initializer_factory.hpp
- src/core/data/ndarray/ndarray_vector.hpp
- src/core/data/particles/particle_array.hpp
- src/core/utilities/box/box.hpp
- src/initializer/data_provider.hpp
- src/initializer/dictator.cpp
- tests/core/data/ions/test_ions.cpp
- tests/simulator/CMakeLists.txt
- tests/simulator/test_tagging.py.off
Additional Context Used
Ruff (46)
pyphare/pyphare/pharein/__init__.py (15)
32-32: Module level import not at top of file
32-32:
.uniform_model.UniformModelimported but unused; consider removing, adding to__all__, or using a redundant alias
33-33: Module level import not at top of file
33-33:
.maxwellian_fluid_model.MaxwellianFluidModelimported but unused; consider removing, adding to__all__, or using a redundant alias
34-34: Module level import not at top of file
34-34:
.electron_model.ElectronModelimported but unused; consider removing, adding to__all__, or using a redundant alias
35-41: Module level import not at top of file
36-36:
.diagnostics.FluidDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
37-37:
.diagnostics.ElectromagDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
38-38:
.diagnostics.ParticleDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
39-39:
.diagnostics.MetaDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
40-40:
.diagnostics.InfoDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
42-46: Module level import not at top of file
43-43:
.simulation.Simulationimported but unused; consider removing, adding to__all__, or using a redundant alias
47-47: Module level import not at top of file
pyphare/pyphare/pharein/load_balancer.py (2)
46-46: f-string without any placeholders
49-49: f-string without any placeholders
pyphare/pyphare/pharein/maxwellian_fluid_model.py (1)
4-4:
pyphare.core.gridlayout.yee_element_is_primalimported but unusedpyphare/pyphare/pharein/simulation.py (7)
338-338: Comparison to
Noneshould becond is not None
358-358: Ambiguous variable name:
l
564-564: f-string without any placeholders
572-572: f-string without any placeholders
692-692: Comparison to
Noneshould becond is not None
949-949: Multiple imports on one line
955-955: Multiple imports on one line
pyphare/pyphare/pharesee/hierarchy.py (1)
668-668: Comparison to
Noneshould becond is Nonepyphare/pyphare/pharesee/particles.py (1)
88-88: f-string without any placeholders
pyphare/pyphare/simulator/simulator.py (4)
110-110: Do not use bare
except
133-133: Do not use bare
except
145-145:
pyphare.cpp.cpp_libimported but unused
164-164: Comparison to
Noneshould becond is not Nonepyphare/pyphare_tests/test_pharesee/test_geometry_3d.py (1)
1-1: Undefined name
test_geometry_3dtests/diagnostic/__init__.py (2)
16-16: Multiple imports on one line
16-16:
numpyimported but unused; consider removing, adding to__all__, or using a redundant aliastests/functional/harris/harris_2d_lb.py (1)
74-74: Ambiguous variable name:
ltests/simulator/__init__.py (7)
4-4: Multiple imports on one line
77-77: Do not assign a
lambdaexpression, use adef
178-178: Undefined name
Box
184-184: Undefined name
Box
191-191: Undefined name
Box
217-217: Local variable
rankis assigned to but never used
218-218: Local variable
envis assigned to but never usedtests/simulator/test_load_balancing.py (1)
73-73: Ambiguous variable name:
ltools/python3/__init__.py (1)
72-72: Module level import not at top of file
tools/python3/caliper.py (2)
6-6:
tools.python3.runimported but unused
20-20:
subprocessimported but unused
Learnings (1)
pyphare/pyphare/pharesee/hierarchy.py (1)
User: PhilipDeegan URL: https://github.com/PHAREHUB/PHARE/pull/807 Timestamp: 2024-04-15T11:57:24.673Z Learning: The `__eq__` method in `ParticleData` uses `self.dataset == that.dataset` for dataset comparison, which might not be sufficient for numpy arrays as it returns an array of booleans. The use of `np.array_equal` is suggested for a more robust comparison.
Additional comments not posted (24)
pyphare/pyphare/simulator/simulator.py (1)
147-147: LGTM!tests/simulator/test_load_balancing.py (1)
200-283: LGTM!pyphare/pyphare/pharein/maxwellian_fluid_model.py (2)
75-75: LGTM!
127-127: LGTM!src/amr/wrappers/integrator.hpp (7)
27-28: Includingload_balancer_details.hppis necessary for theLoadBalancerDetailstype used in the class.
47-54: Theadvancemethod correctly includes a call to_should_rebalance_nowfor load balancing.
56-64: The constructor correctly initializes new member variables and sets up the load balancer.
67-73: The new member variables are necessary for the load balancing logic and their initialization is appropriate.
78-90: ThecomputeNonUniformWorkLoadForLevel0method is well-implemented and necessary for load balancing.
94-99: Thecadence_rebalance_checkmethod is straightforward and necessary for load balancing.
156-166: The constructor definition correctly initializes new member variables and sets up the load balancer.pyphare/pyphare/pharein/__init__.py (2)
228-247: The addition of load balancer parameters in thepopulateDictfunction looks good. Ensure that all necessary parameters for the load balancer are included and correctly set.Verification successful
The
LoadBalancerclass has the following parameters:
activemodetolon_initautonext_rebalance_backoff_multipliernext_rebalancemax_next_rebalanceevery_registerThe
populateDictfunction sets the following parameters:
activemodetolon_initautonext_rebalance_backoff_multipliernext_rebalancemax_next_rebalanceeveryAll necessary parameters for the
LoadBalancerare included and correctly set in thepopulateDictfunction.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all load balancer parameters are included and correctly set in the populateDict function. # Test: Search for the load balancer parameters in the populateDict function. Expect: All necessary parameters are included. rg --type py "load_balancer" ./pyphare/pyphare/pharein/__init__.pyLength of output: 173
Script:
#!/bin/bash # Locate the LoadBalancer class definition and display its parameters. # Find the file containing the LoadBalancer class definition. lb_file=$(fd LoadBalancer.py) # Display the LoadBalancer class definition and its parameters. ast-grep --lang python --pattern $'class LoadBalancer($_, $_):\n def __init__($$$):\n $$$' $lb_fileLength of output: 132
Script:
#!/bin/bash # Search for the LoadBalancer class definition across the entire codebase. # Search for the LoadBalancer class definition. ast-grep --lang python --pattern $'class LoadBalancer($_, $_):\n def __init__($$$):\n $$$'Length of output: 99
Script:
#!/bin/bash # Search for the LoadBalancer class definition using rg and display its parameters. # Search for the LoadBalancer class definition. rg --type py "class LoadBalancer" > load_balancer_class_location.txt # Extract the file path from the search result. lb_file=$(awk -F: '{print $1}' load_balancer_class_location.txt | head -n 1) # Display the LoadBalancer class definition and its parameters. if [ -n "$lb_file" ]; then ast-grep --lang python --pattern $'class LoadBalancer($_, $_):\n def __init__($$$):\n $$$' $lb_file else echo "LoadBalancer class definition not found." fiLength of output: 351
Script:
#!/bin/bash # Display the contents of the file containing the LoadBalancer class. # Display the contents of pyphare/pyphare/pharein/load_balancer.py cat pyphare/pyphare/pharein/load_balancer.pyLength of output: 1725
130-132: Theadd_boolfunction is correctly implemented and follows the pattern of otheradd_*functions.src/simulator/simulator.hpp (4)
Line range hint
4-18: The addition of include statements for load balancing headers is necessary and appropriate for the new functionality.
73-75: The update to thedumpmethod ensures that it returns the result ofdMan->dumpifdManis not null. This is a good addition.
266-293: The load balancing setup in thehybrid_initmethod looks comprehensive. Ensure that all necessary configurations for load balancing are included and correctly set.
Line range hint
392-401: The addition of the logging scope in theadvancemethod is beneficial for debugging and performance monitoring.pyphare/pyphare/pharein/simulation.py (5)
130-131: Ensurestart_timeis correctly used in the function.
150-154: The return statement correctly includesstart_timein the calculation offinal_time.
587-594: Thecheck_loadbalancingfunction correctly validates theloadbalancingkeyword.
651-652: The call tocheck_loadbalancingensures theloadbalancingkeyword is validated.
849-849: The addition ofload_balanceras an attribute in theSimulationclass is correct.src/amr/multiphysics_integrator.hpp (1)
628-628: The declaration ofload_balancer_manager_as aunique_ptris appropriate for managing the lifetime of the load balancer manager instance. Ensure that all necessary checks fornullptrare in place before dereferencing this pointer to maintain robustness.pyphare/pyphare/pharesee/hierarchy.py (1)
258-259: LGTM! The__getitem__method is straightforward and correct.
| def __eq__(self, that): | ||
| return self.field_name == that.field_name and self.dataset[:] == that.dataset[:] |
There was a problem hiding this comment.
Use np.array_equal for robust array comparison in numpy arrays.
- return self.field_name == that.field_name and self.dataset[:] == that.dataset[:]
+ return self.field_name == that.field_name and np.array_equal(self.dataset, that.dataset)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| def __eq__(self, that): | |
| return self.field_name == that.field_name and self.dataset[:] == that.dataset[:] | |
| def __eq__(self, that): | |
| return self.field_name == that.field_name and np.array_equal(self.dataset, that.dataset) |
| def __eq__(self, that): | ||
| return self.name == that.name and self.dataset == that.dataset |
There was a problem hiding this comment.
Use np.array_equal for robust array comparison in numpy arrays.
- return self.name == that.name and self.dataset == that.dataset
+ return self.name == that.name and np.array_equal(self.dataset, that.dataset)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| def __eq__(self, that): | |
| return self.name == that.name and self.dataset == that.dataset | |
| def __eq__(self, that): | |
| return self.name == that.name and np.array_equal(self.dataset, that.dataset) |
| patch_data_ref = patch_ref.patch_datas[patch_data_key] | ||
| patch_data_cmp = patch_cmp.patch_datas[patch_data_key] | ||
|
|
||
| if patch_data_cmp != patch_data_ref: |
There was a problem hiding this comment.
Use np.array_equal for robust array comparison in numpy arrays within hierarchy_compare.
- if patch_data_cmp != patch_data_ref:
+ if not np.array_equal(patch_data_cmp, patch_data_ref):Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| if patch_data_cmp != patch_data_ref: | |
| if not np.array_equal(patch_data_cmp, patch_data_ref): |
| plt.xlabel("timestep") | ||
| fig.savefig("timestep_times.png") | ||
|
|
||
| cpp_lib().mpi_barrier() |
There was a problem hiding this comment.
Consider removing the MPI barrier to avoid unnecessary synchronization unless it is explicitly needed for correctness.
- cpp_lib().mpi_barrier()Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cpp_lib().mpi_barrier() |
Consider removing the MPI barrier to avoid unnecessary synchronization unless it is explicitly needed for correctness.
- cpp_lib().mpi_barrier()Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| cpp_lib().mpi_barrier() |
| rho[np.where(np.isclose(y, 10, atol=0.1))] = 0 | ||
| return rho | ||
|
|
||
| def S(y, y0, l): |
There was a problem hiding this comment.
Rename the variable l to length for clarity and to avoid confusion with the number 1.
- def S(y, y0, l):
+ def S(y, y0, length):Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| def S(y, y0, l): | |
| def S(y, y0, length): |
| # Setup desired cali query. | ||
| # cali_query = "cali-query" | ||
| # grouping_attribute = "function" | ||
| # default_metric = "sum(sum#time.duration),inclusive_sum(sum#time.duration)" | ||
| # query = "select function,%s group by %s format json-split" % ( | ||
| # default_metric, | ||
| # grouping_attribute, | ||
| # ) | ||
|
|
||
| # # Use ``cali-query`` here to produce the json-split stream. | ||
| # with extend_env_path(DEFAULT_CALI_QUERY_PATH): | ||
| # cali_json = subprocess.Popen( | ||
| # [cali_query, "-q", query, cali_file], stdout=subprocess.PIPE | ||
| # ) | ||
|
|
||
| # # Use hatchet's ``from_caliper`` API with the resulting json-split. | ||
| # # The result is stored into Hatchet's GraphFrame. | ||
| # gf = ht.GraphFrame.from_caliper(cali_json.stdout) | ||
|
|
||
| # # Printout the DataFrame component of the GraphFrame. | ||
| # print(gf.dataframe) | ||
|
|
||
| # # Printout the graph component of the GraphFrame. | ||
| # # Use "time (inc)" as the metric column to be displayed | ||
| # print(gf.tree(metric_column="time (inc)")) | ||
|
|
||
| # # Setup desired cali query. | ||
| # grouping_attribute = "function" | ||
| # default_metric = "sum(sum#time.duration),inclusive_sum(sum#time.duration)" | ||
| # query = "select function,%s group by %s format json-split" % ( | ||
| # default_metric, | ||
| # grouping_attribute, | ||
| # ) | ||
|
|
||
| # # Use hatchet's ``from_caliper`` API with the path to the cali file and the | ||
| # # query. This API will internally run ``cali-query`` on this file to | ||
| # # produce a json-split stream. The result is stored into Hatchet's | ||
| # # GraphFrame. | ||
| # with extend_env_path(DEFAULT_CALI_QUERY_PATH): | ||
| # gf = ht.GraphFrame.from_caliper(cali_file, query) | ||
|
|
||
| # # Printout the DataFrame component of the GraphFrame. | ||
| # print(gf.dataframe) | ||
|
|
||
| # # Printout the graph component of the GraphFrame. | ||
| # # Use "time (inc)" as the metric column to be displayed | ||
| # print(gf.tree(metric_column="time (inc)")) |
There was a problem hiding this comment.
Large block of commented-out code detected. Consider removing or justifying this to maintain code cleanliness.
| + 1.0 / np.cosh((y - Ly * 0.7) / L) ** 2 | ||
| ) | ||
|
|
||
| def S(y, y0, l): |
There was a problem hiding this comment.
Rename the variable l to a more descriptive name to avoid ambiguity and improve readability.
- def S(y, y0, l):
+ def S(y, y0, length):Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| def S(y, y0, l): | |
| def S(y, y0, length): |
| bool static _is_tagging_refinement(initializer::PHAREDict const& dict) | ||
| { | ||
| return cppdict::get_value(dict, "simulation/AMR/refinement/tagging/method", | ||
| std::string{"none"}) | ||
| == std::string{"auto"}; | ||
| } |
There was a problem hiding this comment.
Use a constant for the string comparison to improve maintainability.
- return cppdict::get_value(dict, "simulation/AMR/refinement/tagging/method", std::string{"none"}) == std::string{"auto"};
+ const std::string AUTO_TAGGING = "auto";
+ return cppdict::get_value(dict, "simulation/AMR/refinement/tagging/method", std::string{"none"}) == AUTO_TAGGING;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| bool static _is_tagging_refinement(initializer::PHAREDict const& dict) | |
| { | |
| return cppdict::get_value(dict, "simulation/AMR/refinement/tagging/method", | |
| std::string{"none"}) | |
| == std::string{"auto"}; | |
| } | |
| bool static _is_tagging_refinement(initializer::PHAREDict const& dict) | |
| { | |
| const std::string AUTO_TAGGING = "auto"; | |
| return cppdict::get_value(dict, "simulation/AMR/refinement/tagging/method", | |
| std::string{"none"}) | |
| == AUTO_TAGGING; | |
| } |
| return load; | ||
| } | ||
|
|
||
| bool _should_rebalance_now(); |
There was a problem hiding this comment.
Consider refactoring the _should_rebalance_now method to improve readability and maintainability.
- bool _should_rebalance_now();
+ bool _should_rebalance_now(); // Consider refactoring for simplicityAlso applies to: 216-222
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| bool _should_rebalance_now(); | |
| bool _should_rebalance_now(); // Consider refactoring for simplicity |
| bool tolerance_rebalance_check() | ||
| { | ||
| if (rebalance_coarsest_auto_back_off == 0) | ||
| { | ||
| PHARE_LOG_SCOPE(1, "Integrator::_should_rebalance_now::automatic"); | ||
|
|
||
| auto workLoads = core::mpi::collect(computeNonUniformWorkLoadForLevel0()); | ||
| auto const max_value = *std::max_element(workLoads.begin(), workLoads.end()); | ||
| for (auto& workload : workLoads) | ||
| workload /= max_value; | ||
| auto const min_value = *std::min_element(workLoads.begin(), workLoads.end()); | ||
| assert(min_value <= 1); | ||
|
|
||
| if ((1 - min_value) > lb_info_.tolerance) | ||
| { | ||
| rebalance_coarsest_auto_back_off_by = lb_info_.next_rebalance; | ||
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | ||
| return true; | ||
| } | ||
|
|
||
| rebalance_coarsest_auto_back_off_by *= lb_info_.next_rebalance_backoff_multiplier; | ||
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | ||
|
|
||
| if (rebalance_coarsest_auto_back_off > lb_info_.max_next_rebalance) | ||
| rebalance_coarsest_auto_back_off_by = rebalance_coarsest_auto_back_off | ||
| = lb_info_.max_next_rebalance; | ||
| } | ||
|
|
||
| --rebalance_coarsest_auto_back_off; | ||
| return false; | ||
| }; |
There was a problem hiding this comment.
Consider refactoring the tolerance_rebalance_check method to improve readability and maintainability.
- bool tolerance_rebalance_check();
+ bool tolerance_rebalance_check(); // Consider refactoring for simplicityCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| bool tolerance_rebalance_check() | |
| { | |
| if (rebalance_coarsest_auto_back_off == 0) | |
| { | |
| PHARE_LOG_SCOPE(1, "Integrator::_should_rebalance_now::automatic"); | |
| auto workLoads = core::mpi::collect(computeNonUniformWorkLoadForLevel0()); | |
| auto const max_value = *std::max_element(workLoads.begin(), workLoads.end()); | |
| for (auto& workload : workLoads) | |
| workload /= max_value; | |
| auto const min_value = *std::min_element(workLoads.begin(), workLoads.end()); | |
| assert(min_value <= 1); | |
| if ((1 - min_value) > lb_info_.tolerance) | |
| { | |
| rebalance_coarsest_auto_back_off_by = lb_info_.next_rebalance; | |
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | |
| return true; | |
| } | |
| rebalance_coarsest_auto_back_off_by *= lb_info_.next_rebalance_backoff_multiplier; | |
| rebalance_coarsest_auto_back_off = rebalance_coarsest_auto_back_off_by; | |
| if (rebalance_coarsest_auto_back_off > lb_info_.max_next_rebalance) | |
| rebalance_coarsest_auto_back_off_by = rebalance_coarsest_auto_back_off | |
| = lb_info_.max_next_rebalance; | |
| } | |
| --rebalance_coarsest_auto_back_off; | |
| return false; | |
| }; | |
| bool tolerance_rebalance_check(); // Consider refactoring for simplicity |
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
9e669d1
to
0f2686c
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
Outside diff range and nitpick comments (1)
pyphare/pyphare/pharein/__init__.py (1)
Line range hint
32-32: Move module-level imports to the top of the file to improve code organization and readability.+ from .uniform_model import UniformModel + from .maxwellian_fluid_model import MaxwellianFluidModel + from .electron_model import ElectronModel + from .diagnostics import ( + FluidDiagnostics, + ElectromagDiagnostics, + ParticleDiagnostics, + MetaDiagnostics, + InfoDiagnostics, + ) + from .simulation import ( + Simulation, + serialize as serialize_sim, + deserialize as deserialize_sim, + ) + from .load_balancer import LoadBalancer - # All imports moved to the topAlso applies to: 33-33, 34-34, 35-41, 42-46, 47-47
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (6)
- pyphare/pyphare/core/init.py (3 hunks)
- pyphare/pyphare/pharein/init.py (5 hunks)
- pyphare/pyphare/pharein/load_balancer.py (1 hunks)
- src/hdf5/detail/h5/h5_file.hpp (2 hunks)
- tests/simulator/test_load_balancing.py (1 hunks)
- tools/config/config.py (1 hunks)
Files skipped from review due to trivial changes (1)
- src/hdf5/detail/h5/h5_file.hpp
Additional Context Used
Ruff (21)
pyphare/pyphare/pharein/__init__.py (15)
32-32: Module level import not at top of file
32-32:
.uniform_model.UniformModelimported but unused; consider removing, adding to__all__, or using a redundant alias
33-33: Module level import not at top of file
33-33:
.maxwellian_fluid_model.MaxwellianFluidModelimported but unused; consider removing, adding to__all__, or using a redundant alias
34-34: Module level import not at top of file
34-34:
.electron_model.ElectronModelimported but unused; consider removing, adding to__all__, or using a redundant alias
35-41: Module level import not at top of file
36-36:
.diagnostics.FluidDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
37-37:
.diagnostics.ElectromagDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
38-38:
.diagnostics.ParticleDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
39-39:
.diagnostics.MetaDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
40-40:
.diagnostics.InfoDiagnosticsimported but unused; consider removing, adding to__all__, or using a redundant alias
42-46: Module level import not at top of file
43-43:
.simulation.Simulationimported but unused; consider removing, adding to__all__, or using a redundant alias
47-47: Module level import not at top of file
pyphare/pyphare/pharein/load_balancer.py (3)
36-36: f-string without any placeholders
53-53: f-string without any placeholders
56-56: f-string without any placeholders
tests/simulator/test_load_balancing.py (2)
73-73: Ambiguous variable name:
l
218-218: Local variable
diag_diris assigned to but never usedtools/config/config.py (1)
144-144: Local variable
mpi_typeis assigned to but never used
Additional comments not posted (2)
pyphare/pyphare/pharein/load_balancer.py (2)
56-56: Remove the unnecessary f-string as there are no placeholders used.- f"LoadBalancer is already registered to simulation" + "LoadBalancer is already registered to simulation"Likely invalid or redundant comment.
53-53: Remove the unnecessary f-string as there are no placeholders used.- f"LoadBalancer cannot be registered as no simulation exists" + "LoadBalancer cannot be registered as no simulation exists"Likely invalid or redundant comment.
pyphare/pyphare/core/__init__.py
Outdated
| if "PHARE_SKIP_CLI" in os.environ: | ||
| return os.environ["PHARE_SKIP_CLI"] == "1" | ||
|
|
There was a problem hiding this comment.
Consider using a configuration file or environment variable to define the test directory path to increase flexibility and maintainability.
pyphare/pyphare/core/__init__.py
Outdated
| @@ -34,8 +38,7 @@ | |||
|
|
|||
|
|
|||
| def parse_cli_args(): | |||
| default_off = len(sys.argv) == 1 and disabled_for_testing() | |||
| if default_off: | |||
| if disabled_for_testing(): | |||
There was a problem hiding this comment.
Consider setting the default value of --write_reports to False to align with common command-line interface practices where optional behaviors are disabled by default.
|
|
||
| def __post_init__(self): | ||
| if self.auto and self.every: | ||
| raise RuntimeError(f"LoadBalancer cannot work with both 'every' and 'auto'") |
There was a problem hiding this comment.
Remove the unnecessary f-string as there are no placeholders used.
- raise RuntimeError(f"LoadBalancer cannot work with both 'every' and 'auto'")
+ raise RuntimeError("LoadBalancer cannot work with both 'every' and 'auto'")Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| raise RuntimeError(f"LoadBalancer cannot work with both 'every' and 'auto'") | |
| raise RuntimeError("LoadBalancer cannot work with both 'every' and 'auto'") |
| return | ||
|
|
||
| with self.assertRaises(RuntimeError): | ||
| diag_dir = self.run_sim( |
There was a problem hiding this comment.
Remove the unused variable diag_dir to clean up the code.
- diag_dir = self.run_sim(
- self.unique_diag_dir_for_test_case(diag_outputs, ndim, interp),
- dict(active=True, mode="nppc", tol=0.01, **lbkwargs),
- )Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| diag_dir = self.run_sim( |
PhilipDeegan
force-pushed
the
loadBalancer
branch
from
a5b207a
to
4f501ca
Compare
| @@ -575,6 +581,16 @@ def check_clustering(**kwargs): | |||
| return clustering | |||
|
|
|||
|
|
|||
| def check_loadbalancing(**kwargs): | |||
Summary by CodeRabbit
New Features
RunTimerutility for performance measurement.Bug Fixes
Improvements
Tests
Chores