feat: @Symfony:risky - add no_unreachable_default_argument_value (#…

…7863)
PHP-CS-Fixer · Mar 11, 2024 · 14a5ed1 · 14a5ed1
1 parent ac2bbea
commit 14a5ed1
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 8 deletions.
diff --git a/doc/ruleSets/PhpCsFixerRisky.rst b/doc/ruleSets/PhpCsFixerRisky.rst
@@ -27,7 +27,6 @@ Rules
 
   ``['sets' => ['@all']]``
 
-- `no_unreachable_default_argument_value <./../rules/function_notation/no_unreachable_default_argument_value.rst>`_
 - `no_unset_on_property <./../rules/language_construct/no_unset_on_property.rst>`_
 - `php_unit_data_provider_name <./../rules/php_unit/php_unit_data_provider_name.rst>`_
 - `php_unit_data_provider_return_type <./../rules/php_unit/php_unit_data_provider_return_type.rst>`_

diff --git a/doc/ruleSets/SymfonyRisky.rst b/doc/ruleSets/SymfonyRisky.rst
@@ -60,8 +60,3 @@ Rules
 - `string_length_to_empty <./../rules/string_notation/string_length_to_empty.rst>`_
 - `string_line_ending <./../rules/string_notation/string_line_ending.rst>`_
 - `ternary_to_elvis_operator <./../rules/operator/ternary_to_elvis_operator.rst>`_
-
-Disabled rules
---------------
-
-- `no_unreachable_default_argument_value <./../rules/function_notation/no_unreachable_default_argument_value.rst>`_
diff --git a/doc/rules/function_notation/no_unreachable_default_argument_value.rst b/doc/rules/function_notation/no_unreachable_default_argument_value.rst
@@ -40,6 +40,7 @@ The rule is part of the following rule sets:
 - `@PHP80Migration:risky <./../../ruleSets/PHP80MigrationRisky.rst>`_
 - `@PSR12:risky <./../../ruleSets/PSR12Risky.rst>`_
 - `@PhpCsFixer:risky <./../../ruleSets/PhpCsFixerRisky.rst>`_
+- `@Symfony:risky <./../../ruleSets/SymfonyRisky.rst>`_
 
 References
 ----------

diff --git a/src/RuleSet/Sets/PhpCsFixerRiskySet.php b/src/RuleSet/Sets/PhpCsFixerRiskySet.php
@@ -47,7 +47,6 @@ public function getRules(): array
                     '@all',
                 ],
             ],
-            'no_unreachable_default_argument_value' => true,
             'no_unset_on_property' => true,
             'php_unit_data_provider_name' => true,
             'php_unit_data_provider_return_type' => true,

diff --git a/src/RuleSet/Sets/SymfonyRiskySet.php b/src/RuleSet/Sets/SymfonyRiskySet.php
@@ -55,7 +55,6 @@ public function getRules(): array
             'no_homoglyph_names' => true,
             'no_php4_constructor' => true,
             'no_unneeded_final_method' => true,
-            'no_unreachable_default_argument_value' => false,
             'no_useless_sprintf' => true,
             'non_printable_character' => true,
             'ordered_traits' => true,