Merge branch '2.18'

# Conflicts: # tests/AutoReview/ProjectCodeTest.php
PHP-CS-Fixer · Apr 30, 2021 · 3d7e47c · 3d7e47c
2 parents 351fc9c + 4961df4
commit 3d7e47c
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 1 deletion.
diff --git a/src/AbstractFixer.php b/src/AbstractFixer.php
@@ -170,7 +170,7 @@ public function configure(array $configuration = null)
     }
 
     /**
-     * {@inheritdoc}
+     * @return FixerConfigurationResolverInterface
      */
     public function getConfigurationDefinition()
     {

diff --git a/tests/AutoReview/ProjectCodeTest.php b/tests/AutoReview/ProjectCodeTest.php
@@ -553,6 +553,62 @@ static function (Token $token) {
         );
     }
 
+    /**
+     * @dataProvider provideSrcClassCases
+     *
+     * @param string $className
+     */
+    public function testInheritdocIsNotAbused($className)
+    {
+        $rc = new \ReflectionClass($className);
+
+        $allowedMethods = array_map(
+            function (\ReflectionClass $interface) {
+                return $this->getPublicMethodNames($interface);
+            },
+            $rc->getInterfaces()
+        );
+
+        if (\count($allowedMethods)) {
+            $allowedMethods = array_merge(...array_values($allowedMethods));
+        }
+
+        $parentClass = $rc;
+        while (false !== $parentClass = $parentClass->getParentClass()) {
+            foreach ($parentClass->getMethods(\ReflectionMethod::IS_PUBLIC | \ReflectionMethod::IS_PROTECTED) as $method) {
+                $allowedMethods[] = $method->getName();
+            }
+        }
+
+        $allowedMethods = array_unique($allowedMethods);
+
+        $methodsWithInheritdoc = array_filter(
+            $rc->getMethods(),
+            static function (\ReflectionMethod $rm) {
+                return false !== $rm->getDocComment() && stripos($rm->getDocComment(), '@inheritdoc');
+            }
+        );
+        $methodsWithInheritdoc = array_map(
+            static function (\ReflectionMethod $rm) {
+                return $rm->getName();
+            },
+            $methodsWithInheritdoc
+        );
+
+        $extraMethods = array_diff($methodsWithInheritdoc, $allowedMethods);
+
+        static::assertEmpty(
+            $extraMethods,
+            sprintf(
+                "Class '%s' should not have methods with '@inheritdoc' in PHPDoc that are not inheriting PHPDoc.\nViolations:\n%s",
+                $className,
+                implode("\n", array_map(static function ($item) {
+                    return " * {$item}";
+                }, $extraMethods))
+            )
+        );
+    }
+
     public function provideSrcClassCases()
     {
         return array_map(