PhpdocTypesOrderFixer - Prevent unexpected default value change

PHP-CS-Fixer · Nov 2, 2019 · 8b8eca0 · 8b8eca0
1 parent f031f23
commit 8b8eca0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Fixer/Phpdoc/PhpdocTypesOrderFixer.php b/src/Fixer/Phpdoc/PhpdocTypesOrderFixer.php
@@ -132,8 +132,8 @@ protected function applyFix(\SplFileInfo $file, Tokens $tokens)
                 // fix @method parameters types
                 $line = $doc->getLine($annotation->getStart());
                 $line->setContent(Preg::replaceCallback('/(@method\s+.+?\s+\w+\()(.*)\)/', function (array $matches) {
-                    $sorted = Preg::replaceCallback('/((?:^|,)\s*)([^\s]+)/', function (array $matches) {
-                        return $matches[1].$this->sortJoinedTypes($matches[2]);
+                    $sorted = Preg::replaceCallback('/([^\s,]+)([\s]+\$[^\s,]+)/', function (array $matches) {
+                        return $this->sortJoinedTypes($matches[1]).$matches[2];
                     }, $matches[2]);
 
                     return $matches[1].$sorted.')';

diff --git a/tests/Fixer/Phpdoc/PhpdocTypesOrderFixerTest.php b/tests/Fixer/Phpdoc/PhpdocTypesOrderFixerTest.php
@@ -141,6 +141,10 @@ public function provideFixCases()
                 '<?php /** @var null|Foo[]|Foo|Foo\Bar|Foo_Bar */',
                 '<?php /** @var Foo[]|null|Foo|Foo\Bar|Foo_Bar */',
             ],
+            [
+                '<?php /** @method void bar(null|string $delimiter = \',<br/>\') */',
+                '<?php /** @method void bar(string|null $delimiter = \',<br/>\') */',
+            ],
         ];
     }