minor #5499 DX: add TODOs for PHP requirements cleanup (keradus)

This PR was squashed before being merged into the 2.18 branch. Discussion ---------- DX: add TODOs for PHP requirements cleanup Commits ------- 7d588f4 DX: add TODOs for PHP requirements cleanup
PHP-CS-Fixer · Feb 18, 2021 · dd2e3d6 · dd2e3d6
2 parents e2c6a1a + 7d588f4
commit dd2e3d6
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 4 deletions.
diff --git a/src/Fixer/ControlStructure/NoUnneededControlParenthesesFixer.php b/src/Fixer/ControlStructure/NoUnneededControlParenthesesFixer.php
@@ -46,11 +46,12 @@ public function __construct()
     {
         parent::__construct();
 
-        // To be moved back to compile time property declaration when PHP support of PHP CS Fixer will be 7.0+
+        // @TODO: To be moved back to compile time property declaration when PHP support of PHP CS Fixer will be 7.0+
         if (\defined('T_COALESCE')) {
             self::$loops['clone']['forbiddenContents'][] = [T_COALESCE, '??'];
         }
 
+        // @TODO: To be moved back to compile time property declaration when PHP support of PHP CS Fixer will be 7.0+
         if (\defined('T_YIELD_FROM')) {
             self::$loops['yield_from'] = ['lookupTokens' => T_YIELD_FROM, 'neededSuccessors' => [';', ')']];
         }

diff --git a/src/Fixer/ControlStructure/YodaStyleFixer.php b/src/Fixer/ControlStructure/YodaStyleFixer.php
@@ -485,10 +485,12 @@ private function isOfLowerPrecedence(Token $token)
                 T_XOR_EQUAL,    // ^=
             ];
 
+            // @TODO: drop condition when PHP 7.0+ is required
             if (\defined('T_COALESCE')) {
                 $tokens[] = T_COALESCE; // ??
             }
 
+            // @TODO: drop condition when PHP 7.4+ is required
             if (\defined('T_COALESCE_EQUAL')) {
                 $tokens[] = T_COALESCE_EQUAL; // ??=
             }

diff --git a/src/Fixer/LanguageConstruct/SingleSpaceAfterConstructFixer.php b/src/Fixer/LanguageConstruct/SingleSpaceAfterConstructFixer.php
@@ -105,10 +105,12 @@ public function configure(array $configuration = null)
     {
         parent::configure($configuration);
 
+        // @TODO: drop condition when PHP 7.0+ is required
         if (\defined('T_YIELD_FROM')) {
             self::$tokenMap['yield_from'] = T_YIELD_FROM;
         }
 
+        // @TODO: drop condition when PHP 8.0+ is required
         if (\defined('T_MATCH')) {
             self::$tokenMap['match'] = T_MATCH;
         }

diff --git a/src/Fixer/Operator/BinaryOperatorSpacesFixer.php b/src/Fixer/Operator/BinaryOperatorSpacesFixer.php
@@ -457,14 +457,17 @@ private function resolveOperatorsFromConfig()
             }
         }
 
+        // @TODO: drop condition when PHP 7.0+ is required
         if (!\defined('T_SPACESHIP')) {
             unset($operators['<=>']);
         }
 
+        // @TODO: drop condition when PHP 7.0+ is required
         if (!\defined('T_COALESCE')) {
             unset($operators['??']);
         }
 
+        // @TODO: drop condition when PHP 7.4+ is required
         if (!\defined('T_COALESCE_EQUAL')) {
             unset($operators['??=']);
         }

diff --git a/src/Fixer/Operator/NewWithBracesFixer.php b/src/Fixer/Operator/NewWithBracesFixer.php
@@ -95,6 +95,7 @@ protected function applyFix(\SplFileInfo $file, Tokens $tokens)
                 [CT::T_BRACE_CLASS_INSTANTIATION_CLOSE],
             ];
 
+            // @TODO: drop condition when PHP 7.0+ is required
             if (\defined('T_SPACESHIP')) {
                 $nextTokenKinds[] = [T_SPACESHIP];
             }

diff --git a/src/Fixer/Whitespace/BlankLineBeforeStatementFixer.php b/src/Fixer/Whitespace/BlankLineBeforeStatementFixer.php
@@ -71,7 +71,7 @@ public function __construct()
     {
         parent::__construct();
 
-        // To be moved back to compile time property declaration when PHP support of PHP CS Fixer will be 7.0+
+        // @TODO: To be moved back to compile time property declaration when PHP support of PHP CS Fixer will be 7.0+
         if (\defined('T_YIELD_FROM')) {
             self::$tokenMap['yield_from'] = T_YIELD_FROM;
         }

diff --git a/src/Linter/TokenizerLinter.php b/src/Linter/TokenizerLinter.php
@@ -27,7 +27,12 @@ final class TokenizerLinter implements LinterInterface
 {
     public function __construct()
     {
-        if (false === \defined('TOKEN_PARSE') || false === class_exists(\CompileError::class)) {
+        if (
+            // @TODO: drop condition when PHP 7.0+ is required
+            false === \defined('TOKEN_PARSE')
+            // @TODO: drop condition when PHP 7.3+ is required
+            || false === class_exists(\CompileError::class)
+        ) {
             throw new UnavailableLinterException('Cannot use tokenizer as linter.');
         }
     }

diff --git a/src/Tokenizer/Analyzer/CommentsAnalyzer.php b/src/Tokenizer/Analyzer/CommentsAnalyzer.php
@@ -85,6 +85,7 @@ public function isBeforeStructuralElement(Tokens $tokens, $index)
         do {
             $nextIndex = $tokens->getNextMeaningfulToken($nextIndex);
 
+            // @TODO: drop condition when PHP 8.0+ is required
             if (\defined('T_ATTRIBUTE')) {
                 while (null !== $nextIndex && $tokens[$nextIndex]->isGivenKind(T_ATTRIBUTE)) {
                     $nextIndex = $tokens->findBlockEnd(Tokens::BLOCK_TYPE_ATTRIBUTE, $nextIndex);

diff --git a/src/Tokenizer/Tokens.php b/src/Tokenizer/Tokens.php
@@ -276,6 +276,7 @@ public static function getBlockEdgeDefinitions()
             ],
         ];
 
+        // @TODO: drop condition when PHP 8.0+ is required
         if (\defined('T_ATTRIBUTE')) {
             $definitions[self::BLOCK_TYPE_ATTRIBUTE] = [
                 'start' => [T_ATTRIBUTE, '#['],
@@ -1092,7 +1093,7 @@ public function setCode($code)
         // clear memory
         $this->setSize(0);
 
-        $tokens = \defined('TOKEN_PARSE')
+        $tokens = \defined('TOKEN_PARSE') // @TODO: drop condition when PHP 7.0+ is required
             ? token_get_all($code, TOKEN_PARSE)
             : token_get_all($code);
 

diff --git a/src/Tokenizer/TokensAnalyzer.php b/src/Tokenizer/TokensAnalyzer.php
@@ -560,14 +560,17 @@ public function isBinaryOperator($index)
                 CT::T_TYPE_ALTERNATION => true, // |
             ];
 
+            // @TODO: drop condition when PHP 7.0+ is required
             if (\defined('T_SPACESHIP')) {
                 $arrayOperators[T_SPACESHIP] = true; // <=>
             }
 
+            // @TODO: drop condition when PHP 7.0+ is required
             if (\defined('T_COALESCE')) {
                 $arrayOperators[T_COALESCE] = true;  // ??
             }
 
+            // @TODO: drop condition when PHP 7.4+ is required
             if (\defined('T_COALESCE_EQUAL')) {
                 $arrayOperators[T_COALESCE_EQUAL] = true;  // ??=
             }

diff --git a/tests/Tokenizer/TokenTest.php b/tests/Tokenizer/TokenTest.php
@@ -151,6 +151,7 @@ public function provideIsCommentCases()
             yield $index => $test;
         }
 
+        // @TODO: drop condition when PHP 8.0+ is required
         if (\defined('T_ATTRIBUTE')) {
             yield [new Token([T_ATTRIBUTE, '#[', 1]), false];
         }