DX: do not allow overriding constructor of `PHPUnit\Framework\TestCas…

…e` (#7563)
PHP-CS-Fixer · Dec 15, 2023 · fd3b0a2 · fd3b0a2
1 parent 4c57217
commit fd3b0a2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/tests/Smoke/InstallViaComposerTest.php b/tests/Smoke/InstallViaComposerTest.php
@@ -32,7 +32,7 @@
  */
 final class InstallViaComposerTest extends AbstractSmokeTestCase
 {
-    private Filesystem $fs;
+    private ?Filesystem $fs;
 
     /** @var array<string, mixed> */
     private array $currentCodeAsComposerDependency = [
@@ -64,13 +64,6 @@ final class InstallViaComposerTest extends AbstractSmokeTestCase
         'vendor/bin/php-cs-fixer fix --help',
     ];
 
-    public function __construct()
-    {
-        $this->fs = new Filesystem();
-
-        parent::__construct();
-    }
-
     public static function setUpBeforeClass(): void
     {
         parent::setUpBeforeClass();
@@ -98,6 +91,16 @@ public static function setUpBeforeClass(): void
         }
     }
 
+    protected function setUp(): void
+    {
+        $this->fs = new Filesystem();
+    }
+
+    protected function tearDown(): void
+    {
+        $this->fs = null;
+    }
+
     public function testInstallationViaPathIsPossible(): void
     {
         $tmpPath = $this->createFakeComposerProject($this->currentCodeAsComposerDependency);

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -25,4 +25,14 @@
 abstract class TestCase extends BaseTestCase
 {
     use ExpectDeprecationTrait;
+
+    final public function testNotDefiningConstructor(): void
+    {
+        $reflection = new \ReflectionObject($this);
+
+        self::assertNotSame(
+            $reflection->getConstructor()->getDeclaringClass()->getName(),
+            $reflection->getName(),
+        );
+    }
 }