Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing integration test when short_open_tag=on #1615

Closed
gharlan opened this issue Dec 20, 2015 · 0 comments
Closed

Failing integration test when short_open_tag=on #1615

gharlan opened this issue Dec 20, 2015 · 0 comments

Comments

@gharlan
Copy link
Contributor

gharlan commented Dec 20, 2015

When running phpunit locally, I get this failure:

1) Symfony\CS\Tests\IntegrationTest::testIntegration with data set #1 ('misc/php_closing_tag,short_tag.test', 'Integration of fixers: php_cl...t_tag.', array(Symfony\CS\Fixer\PSR1\ShortTagFixer Object (), Symfony\CS\Fixer\PSR2\PhpClosingTagFixer Object ()), array(false, '7.0.0'), '<?\n$a = 1;\n\n?>', '<?php\n$a = 1;')
Set priorities must be significant. If fixers used in reverse order return same output then the integration test is not sufficient or the priority relation between used fixers should not be set.
Failed asserting that two strings are not identical.

Reason: short_open_tag is enabled, so the priority of ShortTagFixer is irrelevant.

@keradus keradus closed this as completed Feb 1, 2016
keradus added a commit that referenced this issue Feb 1, 2016
…short_tag fixer (keradus)

This PR was merged into the 1.12 branch.

Discussion
----------

Integration tests - don't check priority for tests using short_tag fixer

Closes #1615

Commits
-------

74f0ef7 Integration tests - don't check priority for tests using short_tag fixer
SpacePossum added a commit that referenced this issue Dec 15, 2021
…urreau)

This PR was merged into the master branch.

Discussion
----------

gitlab reporter - add fixed severity to match format

fix #6175

Following discussion here #1615, I created a simple fix.

Please tell me if I miss something.

Commits
-------

5286244 #1615 fix gitlab format by adding default severity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants