Add no_root_imports fixer #4347
Labels
Comments
SpacePossum
added a commit
that referenced
this issue
Oct 11, 2019
This PR was squashed before being merged into the 2.16-dev branch (closes #4355). Discussion ---------- GlobalNamespaceImportFixer - Introduction * closes #1309 * refs #2166 (this pr does not differientiate between native/non-native elements, only between global/non-global) * closes #2739 * closes #4347 --- The fixer can import global classes/functions/constants: Input: ```php <?php namespace Foo; if (\count($x)) { /** @var \DateTimeImmutable $d */ $d = new \DateTimeImmutable(); $p = \M_PI; } ``` Output: ```php <?php namespace Foo; use DateTimeImmutable; use function count; use const M_PI; if (count($x)) { /** @var DateTimeImmutable $d */ $d = new DateTimeImmutable(); $p = M_PI; } ``` Global functions/constants without leading `\` are not imported. The slash can be added by `Native(Constant|Function)InvocationFixer` before. The fixer can also do the reverse fix, adding the backslash to imported global classes/functions/constants. But the fixer does not remove the imports, this can be done by `NoUnusedImportsFixer`. Commits ------- 41fe1f4 GlobalNamespaceImportFixer - Introduction
|
done in #4355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With this fixer, an import such as
use PDO;would be removed and all references toPDOin that file would be replaced with\PDO. Root imports are those which do not contain a backslash (\) character, excluding the first. The following are root imports:PDO\PDOThe following are not root imports:
Foo\Bar.The rationale behind this fixer is to make it clear, when reading the code, whether the built-in implementation is used or a custom implementation. That is, when code follows the no root imports style, we can be confident that code occurences of
\PDOrefer to the standard implementation, andPDOrefers to a custom implementation, because PHP built-in classes are not namespaced.The text was updated successfully, but these errors were encountered: