Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "sortAlgorithm" option of "ordered_class_elements" fixer to "sort_algorithm"? #4389

Closed
jaydiablo opened this issue Apr 25, 2019 · 2 comments
Closed

Change "sortAlgorithm" option of "ordered_class_elements" fixer to "sort_algorithm"? #4389

jaydiablo opened this issue Apr 25, 2019 · 2 comments
Labels
kind/enhancement

Comments

@jaydiablo
Copy link
Contributor

The ordered_class_elements fixer has a sort algorithm option that uses camel case for the option (sortAlgorithm), all other fixers that have the same option use snake case (sort_algorithm). It seems that the ordered_imports fixer has deprecated the camel case version already.

Should the camel case syntax be deprecated for the ordered_class_elements fixer as well, for consistency?
@SpacePossum
Copy link
Contributor

Hi and thanks for reporting 👍

Looks like a good change, having a unit test to prevent camel cased options getting added would be great as well

@kubawerlos kubawerlos mentioned this issue Nov 9, 2019
Merged
@kubawerlos
Copy link
Contributor

@SpacePossum we have that test :)

keradus added a commit that referenced this issue Nov 23, 2019
@keradus
minor #4634 Make all options snake_case (kubawerlos)
a4513fa 
This PR was merged into the 2.17-dev branch.

Discussion
----------

Make all options snake_case

Resolves #4389

Commits
-------

369a7b1 Make all options snake_case
@keradus keradus closed this as completed Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jaydiablo @keradus @kubawerlos @SpacePossum