New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.16.8 crash because of symfony/polyfill-mbstring #5324
Comments
This seems to be an issue with the PHAR distribution of PHP CS Fixer 2.16.8. The PHAR of 2.16.7 works fine and if I install 2.16.8 via composer as a dependency of my project, |
@derrabus yes this is what I suspected... packaging issue. |
(ping @keradus maybe for this evening) |
Same problem with 2.17.0. |
I'll try to find some time tonight. I'm pretty sure though that this has to be fixed not in this repository but in the polyfill's. |
#5332 fix this |
I guess I was wrong. 😅 Thank you @jderusse! |
actually the issue came due to changes in polyfills :( https://github.com/symfony/polyfill/pull/287/files |
Yes. The name of that new file was probably a bit unexpected. |
(milestone removed to have milestones on PRs only) |
I can confirm that the 2.17.1 PHAR works flawlessly on PHP 8. Thank you very much for the quick fix! ❤️ |
thanks for reporting back, great to hear it works :D |
I still seem to be experiencing this on 2.17.1: https://app.circleci.com/pipelines/github/algolia/algoliasearch-client-php/101/workflows/68475022-554b-4364-b631-811f39e5f9cb/jobs/507 |
Your link takes me to a login page, @driesvints. 😢 |
Sorry about that. Here's the screenshots of the build: It's for the following PR: algolia/algoliasearch-client-php#644 (although I've disabled PHP CS Fixer again on PHP 8 in order to continue with it) |
Hi @driesvints , |
@driesvints That's a different issue. Running PHP CS Fixer on PHP 8 is considered experimental, so you still need to set an environment variable |
Ah sorry everyone. Someone on the PR made the false assumption that PHP 8 is now supported on PHP CS Fixer which I didn't verify myself. My bad! |
Bug report
I'm using php 8.0.0 with mbstring extension loaded. I know php8 is not fully supported at the moment but it works pretty well with previous cs-fixer release and env var
PHP_CS_FIXER_IGNORE_ENV=1
.Code snippet that reproduces the problem
Just run ph-cs-fixer --version for example
The text was updated successfully, but these errors were encountered: