Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the signature of polyfills on PHP >= 8 #316

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Verify the signature of polyfills on PHP >= 8 #316

merged 1 commit into from
Dec 27, 2020

Conversation

nicolas-grekas
Copy link
Member

No description provided.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Dec 26, 2020

PR is ready. I would appreciate help to fix the failures on PHP 8 once it's merged 🙏

@Ayesh
Copy link
Contributor

Ayesh commented Dec 26, 2020

Errors: 54, Failures: 18, Warnings: 2

This is much more manageable and miles ahead of what we had before. Thank you for this amazing work @nicolas-grekas 🙏🏼. I will try to work on further fixes in coming days.

src/Apcu/bootstrap.php Outdated Show resolved Hide resolved
@derrabus
Copy link
Member

I would appreciate help to fix the failures on PHP 8 once it's merged 🙏

🙋🏻

I'll pick (rolls dice) the UUID polyfill.

@nicolas-grekas nicolas-grekas merged commit 9269bda into symfony:main Dec 27, 2020
@nicolas-grekas nicolas-grekas deleted the sign-check branch December 27, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants