function join() and list($content, ) should not be check... #930
Labels
Comments
|
This is fixed already. |
|
Will be included in the 1.4 release. |
|
@GrahamCampbell @keradus please close this issue as it is already fixed |
|
Yeh, I would have closed it, but I'm not a collaborator. :P |
|
oh, I thought you were |
|
i'm closing it. thanks ;) |
|
Yeah, that is why issue reports shouldn't be closed so willingly. Please see solution at #952 |
|
@keradus thank you ;) |
keradus
added a commit
that referenced
this issue
Jan 4, 2015
…ma (keradus) This PR was merged into the 2.0-dev branch. Discussion ---------- ParenthesisFixer - fix case with list call with trailing comma Fix #930 Note: Should be merged into 1.4 branch as setted in milestone, not master as setted in PR. Consider following code: `<?php list($path, $mode,) = foo();` If we run MethodArgumentSpaceFixer on it, it will add a space after comma: `<?php list($path, $mode, ) = foo();` Then if we run ParenthesisFixer it will remove that space: `<?php list($path, $mode,) = foo();` This PR change behavior of ParenthesisFixer - stop removing space if there is trailing comma. Also added a tests for it in both fixers. Commits ------- b02b097 ParenthesisFixer - fix case with list call with trailing comma
keradus
added a commit
that referenced
this issue
Jan 4, 2015
…ma (keradus) This PR was merged into the 1.4 branch. Discussion ---------- ParenthesisFixer - fix case with list call with trailing comma Fix #930 Clone #952 Consider following code: `<?php list($path, $mode,) = foo();` If we run MethodArgumentSpaceFixer on it, it will add a space after comma: `<?php list($path, $mode, ) = foo();` Then if we run ParenthesisFixer it will remove that space: `<?php list($path, $mode,) = foo();` This PR change behavior of ParenthesisFixer - stop removing space if there is trailing comma. Also added a tests for it in both fixers. Commits ------- 0db8e07 ParenthesisFixer - fix case with list call with trailing comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think when using 'querybuilder' like :
the join() function should not be check and changed to implode. see my comment at : zendframework/zendframework#7079 (diff)
and about :
should not be check too, see my comment at zendframework/zendframework#7079 (diff) that space not removed, then "parenthesis" cs, but when it removed, it makes another error : "method_argument_space".
The text was updated successfully, but these errors were encountered: