-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhpdocTypesFixer - support iterable type #2196
Conversation
oops |
isn't it's there? 2nd position of initial comment |
Nice ! Could you please add small integration test for 7.1 (like this: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/1.12/Symfony/CS/Tests/Fixtures/Integration/misc/PHP7.test) ? I'm not saying to add all 7.1 (which of course would be nice), but at least |
Why PHP 7.1. This phpdoc type can be used on any version, the same way |
iterable is not only for typedoc. |
This fixer change has nothing to do with actual typehints though, so in the interest of keeping this atomic, I shouldn't make an unrelated change. |
then this PR would make false sense of feeling we support the iterable, even if we would support it only in doctype. big -1 for that |
Thank you @GrahamCampbell. |
This PR was merged into the 1.12 branch. Discussion ---------- PhpdocTypesFixer - support iterable type PHP 7.1 will have the `iterable` type. We should treat it like the other types we normalize. Refs: * https://wiki.php.net/rfc/iterable * php/php-src#1941 * https://github.com/php/php-src/blob/php-7.1.0RC2/UPGRADING#L25-L27 Commits ------- 0d8da6e Added support for the new iterable type
awesome, thanks @GrahamCampbell ! |
PHP 7.1 will have the
iterable
type. We should treat it like the other types we normalize.Refs: