DX: Add AutoReview/ComposerTest #3556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
reviewed
Feb 21, 2018
tests/AutoReview/ComposerTest.php
Outdated
| $composerJson = json_decode(file_get_contents(__DIR__.'/../../composer.json'), true); | ||
|
|
||
| if (!isset($composerJson['extra']['branch-alias'])) { | ||
| $this->assertTrue(true); // composer.json doesn't contain branch alias, all good! |
There was a problem hiding this comment.
? maybe better to just increase the assert count and not an always pass assert?
There was a problem hiding this comment.
I was looking for that at night, could you please remind me the method ?
There was a problem hiding this comment.
That's why I couldn't find it :D
ker@dus:~/github/PHP-CS-Fixer λ git grep addToAssertionCount
ker@dus:~/github/PHP-CS-Fixer λ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #3555
So, during merging one line into another, I will not mess up with branch aliasing