Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some more classes final #3922

Merged
merged 1 commit into from Mar 18, 2019
Merged

Make some more classes final #3922

merged 1 commit into from Mar 18, 2019

Conversation

ntzm
Copy link
Contributor

@ntzm ntzm commented Jul 15, 2018

Not Config and Finder as they are extension points.

@keradus
Copy link
Member

keradus commented Jul 15, 2018

-0
+1 when we will have nice rule for that

@keradus
Copy link
Member

keradus commented Jul 15, 2018

Rule > AutoReview
all except listed one is too demanding, nice reasoning is good to have, i won't provide full spec now, but Doctrine ORM classes shall not be final

@ntzm
Copy link
Contributor Author

ntzm commented Jul 15, 2018

#3923

@SpacePossum
Copy link
Contributor

I think this is RTM TBH

@SpacePossum SpacePossum added RTM Ready To Merge and removed waiting review labels Mar 18, 2019
@SpacePossum SpacePossum added this to the 3.0.0 milestone Mar 18, 2019
@SpacePossum
Copy link
Contributor

Thank you @ntzm.

@SpacePossum SpacePossum merged commit 212630b into PHP-CS-Fixer:3.0 Mar 18, 2019
SpacePossum added a commit that referenced this pull request Mar 18, 2019
@SpacePossum
minor #3922 Make some more classes final (ntzm, SpacePossum)
5d34598 
This PR was squashed before being merged into the 3.0 branch (closes #3922).

Discussion
----------

Make some more classes final

Not Config and Finder as they are extension points.

Commits
-------

212630b Make some more classes final
@SpacePossum SpacePossum removed the RTM Ready To Merge label Mar 18, 2019
@ntzm
Copy link
Contributor Author

ntzm commented Mar 18, 2019

Thanks! I'll be contributing again soon hopefully 🤞

@ntzm ntzm deleted the make-classes-final branch March 18, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ntzm @keradus @SpacePossum