NoUnsetOnPropertyFixer - fix for function call with class constant inside #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
reviewed
Oct 8, 2018
| for ($index = 0; $index < $tokens->count(); ++$index) { | ||
| if ('(' === $tokens[$index]->getContent()) { | ||
| $index = $tokens->findBlockEnd( | ||
| Tokens::BLOCK_TYPE_PARENTHESIS_BRACE, |
There was a problem hiding this comment.
indenting is bit off here I think
|
looking good, please fix the CS minor, Travis failure is not related (existing test is to slow) |
|
Does this fix #3843 too? (Would be awesome 😉) |
|
Unfortunately no, I see a good test case there so will try to solve it as well. |
|
I guess we should mention here that this is being superseeded by #4022? 😉 |
|
Exactly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.