DX: NativeFunctionInvocationFixer - simplify interation #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
approved these changes
Jan 2, 2019
keradus
requested changes
Jan 4, 2019
keradus
added a commit
that referenced
this pull request
Jan 25, 2021
This PR was squashed before being merged into the 2.18 branch. Discussion ---------- POC Tokens::insertSlices ref #4221 cc @kubawerlos , this is what we discussed in priv Commits ------- 07cf8b0 POC Tokens::insertSlices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have to iterate, collect indices, reverse them and insert
\- we can simply iterate in the other direction and insert\during iteration.