Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: remove Utils::splitLines #4232

Merged
merged 1 commit into from
Jan 4, 2019
Merged

DX: remove Utils::splitLines #4232

merged 1 commit into from
Jan 4, 2019

Conversation

kubawerlos
Copy link
Contributor

This is the surprise mentioned here.

Class Utils is internal so no backward compatibility break.

@keradus keradus added this to the 2.12.6 milestone Jan 4, 2019
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when CI are green

@keradus
Copy link
Member

keradus commented Jan 4, 2019

Thank you @kubawerlos.

@keradus keradus merged commit 4cf6902 into PHP-CS-Fixer:2.12 Jan 4, 2019
keradus added a commit that referenced this pull request Jan 4, 2019
This PR was merged into the 2.12 branch.

Discussion
----------

DX: remove Utils::splitLines

This is the surprise mentioned [here](#4205 (comment)).

Class `Utils` is internal so no [backward compatibility](https://symfony.com/doc/current/contributing/code/bc.html) break.

Commits
-------

4cf6902 DX: remove Utils::splitLines
@kubawerlos kubawerlos deleted the dx-remove-utlis-split-lines branch January 4, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants