LineEndingFixer - BracesFixer - Priority #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all the profiling on priorities! --edit: bunch of typos and wording |
|
I just checked, braces never inserts hardcoded newlines, they come from the whitespace config. It does do some string-magic with |
keradus
added a commit
that referenced
this pull request
Feb 3, 2019
… priority issue (dmvdbrugge) This PR was merged into the 2.12 branch. Discussion ---------- MethodChainingIndentationFixer, ArrayIndentationFixer - Fix priority issue Fixes #4271. Pre-2.12.5 `MethodChainingIndentationFixer` had no priority, I introduced it in #4084. It now needs to be upped because it needs to keep running before `ArrayIndentationFixer`. Lowering `ArrayIndentationFixer` was not an option as it already has multiple fixers running after it (which are in the `FixerFactoryTest`, but not in its comments, however the comments are already being fixed in #4245). Commits ------- a6bd13c MethodChainingIndentationFixer should run before ArrayIndentationFixer
SpacePossum
approved these changes
Apr 4, 2019
SpacePossum
force-pushed
the
line_ending_before_braces
branch
from
a57802c
to
33f5fcd
Compare
|
note to self, 7.3 failures are not related to this PR |
|
Thank you @dmvdbrugge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated the
line_ending/braces-priority relation and some comments from #4085