[HeredocIndentationFixer] Should be run before NoTrailingWhitespaceFixer

[phansys]

With the proposed configuration, the expected result for this snippet

<?php
····$a·=·<<<'EOD'
first line

ending line
EOD;

should be

<?php
····$a·=·<<<'EOD'
········first line

········ending line
EOD;

instead of

<?php
····$a·=·<<<'EOD'
········first line
········
········ending line
EOD;

[SpacePossum]

Hi!

Thanks for this PR, much appreciated!
Looking at the issue I wonder, maybe the HeredocIndentationFixer shouldn't indent empty lines so the NoTrailingWhitespaceFixer doesn't have to remove the added indent?

Ping @gharlan as author of HeredocIndentationFixer, WDYT?

[gharlan]

Looking at the issue I wonder, maybe the HeredocIndentationFixer shouldn't indent empty lines so the NoTrailingWhitespaceFixer doesn't have to remove the added indent?

I agree here!

[SpacePossum]

closing as #4548 has been merged :) thanks @gharlan