Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: remove empty sets from RuleSet #4432

Merged
merged 1 commit into from Jul 25, 2019
Merged

DX: remove empty sets from RuleSet #4432

merged 1 commit into from Jul 25, 2019

Conversation

kubawerlos
Copy link
Contributor

As requested by @keradus

@keradus
Copy link
Member

keradus commented Jun 2, 2019

i had to request it sooo long ago ;) can't remember about this

keradus
keradus reviewed Jun 2, 2019
View reviewed changes
tests/RuleSetTest.php Outdated Show resolved Hide resolved
@keradus keradus added this to the 3.0.0 milestone Jun 2, 2019
keradus
keradus reviewed Jun 2, 2019
View reviewed changes
tests/RuleSetTest.php Outdated Show resolved Hide resolved
keradus
keradus reviewed Jun 2, 2019
View reviewed changes
.php_cs.dist Show resolved Hide resolved
keradus
keradus reviewed Jun 3, 2019
View reviewed changes
.php_cs.dist Show resolved Hide resolved
@keradus keradus added the RTM Ready To Merge label Jun 4, 2019
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit 2f34481 into PHP-CS-Fixer:3.0 Jul 25, 2019
SpacePossum added a commit that referenced this pull request Jul 25, 2019
@SpacePossum
minor #4432 DX: remove empty sets from RuleSet (kubawerlos)
b57535a 
This PR was merged into the 3.0 branch.

Discussion
----------

DX: remove empty sets from RuleSet

As requested by @keradus

Commits
-------

2f34481 DX: remove empty sets from RuleSet
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jul 25, 2019
@kubawerlos kubawerlos deleted the remove-empty-rule-sets branch July 25, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/BC break
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @keradus @SpacePossum