Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpdocToParamTypeFixer - cover more cases #4605

Merged
merged 2 commits into from Nov 25, 2019
Merged

Conversation

keradus
Copy link
Member

@keradus keradus commented Oct 21, 2019

ref #4583

@jg-development, @SpacePossum ,
can you pick it up, please?

@julienfalque
Copy link
Member

julienfalque commented Oct 21, 2019

If you don't mind, I'd like to add those to #4591.

Edit: done.

@jg-development
Copy link
Contributor

What about the string[]|int[] case?

@julienfalque
Copy link
Member

It should already be covered by #4591.

@jg-development
Copy link
Contributor

I am trying to look into that today

@julienfalque julienfalque changed the base branch from master to 2.16 November 24, 2019 13:05
@julienfalque julienfalque force-pushed the 2.16_4583 branch 2 times, most recently from c31e975 to 669c61b Compare November 24, 2019 13:39
@keradus keradus added this to the 2.16.1 milestone Nov 25, 2019
@keradus keradus changed the title PhpdocToParamTypeFixer - add failing cases PhpdocToParamTypeFixer - cover more cases Nov 25, 2019
@keradus
Copy link
Member Author

keradus commented Nov 25, 2019

Thank you @julienfalque.

keradus added a commit that referenced this pull request Nov 25, 2019
…alque)

This PR was merged into the 2.16 branch.

Discussion
----------

PhpdocToParamTypeFixer - cover more cases

ref #4583

@jg-development, @SpacePossum ,
can you pick it up, please?

Commits
-------

1ef71ae fixup! PhpdocToParamTypeFixer - add failing cases
4105c5f PhpdocToParamTypeFixer - add failing cases
@keradus keradus merged commit 1ef71ae into PHP-CS-Fixer:2.16 Nov 25, 2019
@keradus keradus deleted the 2.16_4583 branch November 27, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants