Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated no_short_echo_tag rule #4697

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1073,11 +1073,6 @@ Choose from the list of available rules:

Short cast ``bool`` using double exclamation mark should not be used.

* **no_short_echo_tag**

Replaces short-echo ``<?=`` with long format ``<?php echo`` syntax.
DEPRECATED: use ``echo_tag_syntax`` instead.

* **no_singleline_whitespace_before_semicolons** [@Symfony, @PhpCsFixer]

Single-line whitespace before closing semicolon are prohibited.
Expand Down
1 change: 1 addition & 0 deletions UPGRADE-v3.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Old name | New name | Note
`lowercase_constants` | `constant_case` | use configuration `['case' => 'lower']`
`method_separation` | `class_attributes_separation` | use configuration `['elements' => ['method']]`
`no_extra_consecutive_blank_lines` | `no_extra_blank_lines` |
`no_short_echo_tag` | `echo_tag_syntax` | use configuration `['format' => 'long']`
`php_unit_ordered_covers` | `phpdoc_order_by_value` | use configuration `['annotations' => [ 'covers' ]]`
`pre_increment` | `increment_style` | use configuration `['style' => 'pre']`
`silenced_deprecation_error` | `error_suppression` |
Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Alias/NoMixedEchoPrintFixer.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function getDefinition()
*/
public function getPriority()
{
// should run after NoShortEchoTagFixer / EchoTagSyntaxFixer.
// should run after EchoTagSyntaxFixer.
return -10;
}

Expand Down
53 changes: 0 additions & 53 deletions src/Fixer/PhpTag/NoShortEchoTagFixer.php

This file was deleted.

1 change: 0 additions & 1 deletion tests/AutoReview/FixerFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ public function provideFixersPriorityCases()
[$fixers['native_function_invocation'], $fixers['global_namespace_import']],
[$fixers['no_php4_constructor'], $fixers['ordered_class_elements']],
[$fixers['no_short_bool_cast'], $fixers['cast_spaces']],
[$fixers['no_short_echo_tag'], $fixers['no_mixed_echo_print']],
[$fixers['no_spaces_after_function_name'], $fixers['function_to_constant']],
[$fixers['no_spaces_inside_parenthesis'], $fixers['function_to_constant']],
[$fixers['no_superfluous_phpdoc_tags'], $fixers['no_empty_phpdoc']],
Expand Down
47 changes: 0 additions & 47 deletions tests/Fixer/PhpTag/NoShortEchoTagFixerTest.php

This file was deleted.

This file was deleted.