HeredocIndentationFixer - config option for indentation level #4880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed the best indentation level for the HeredocIndentationFixer here and here.
But now since I'm actually using it, I changed my mind.
I would like to write code like this:
and NOT:
So I suggest to add a config option
indentation
with possible valuesstart_plus_one
(default; same as current behavior) andsame_as_start
(new behavior). (Ideas for better names?)The fixer will remain non-risky, so it does not change the actual string result.
This input:
will be changed with the new behavior (
same_as_start
) to:Adding one more indentation level inside string content is not part of this fixer (as it would be risky).