Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpdocTrimConsecutiveBlankLineSeparationFixer - must run after AlignMultilineCommentFixer #5017

Merged
merged 1 commit into from
Jul 3, 2020
Merged

PhpdocTrimConsecutiveBlankLineSeparationFixer - must run after AlignMultilineCommentFixer #5017

merged 1 commit into from
Jul 3, 2020

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@SpacePossum
Copy link
Contributor

Your test prove the priority issue, however after testing I'm not sure why this dependency is here based on your example. Can you talk me through it?

@kubawerlos
Copy link
Contributor Author

For the example:

<?php
/**
 * foo
 *

 * bar
 */

first fixer - align_multiline_comment - "aligns" the empty line, which in this case means making it *.

@SpacePossum SpacePossum added the RTM Ready To Merge label Jun 30, 2020
@SpacePossum SpacePossum added this to the 2.15.9 milestone Jun 30, 2020
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum removed the RTM Ready To Merge label Jul 3, 2020
@SpacePossum SpacePossum merged commit a559874 into PHP-CS-Fixer:2.15 Jul 3, 2020
@kubawerlos kubawerlos deleted the fix_PhpdocTrimConsecutiveBlankLineSeparationFixer branch July 3, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants