Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SingleLineAfterImportsFixer - fix for line after import (and before another import) already added using CRLF #5032

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Jun 28, 2020

The original test for CRLF was run in tests for PHP 7.0, so in this PR it's moved to test which runs on all PHP versions.

Follow up to #5029

@kubawerlos kubawerlos marked this pull request as ready for review June 28, 2020 19:18
@SpacePossum
Copy link
Contributor

Maybe we can add a test step to Travis to run the fixer on its own code base with line break setting to \r\n and than run it again with \n and test the code is still the same ;)

@SpacePossum SpacePossum added the RTM Ready To Merge label Jun 30, 2020
@kubawerlos
Copy link
Contributor Author

kubawerlos commented Jun 30, 2020

@SpacePossum I was about adding a test in AutoReview when we test code samples that would take each code sample after fixing, run \n -> \r\n\ replace and check if nothing is changed. Of course, there would be some exceptions like line_ending fixer. WDYT?

@SpacePossum
Copy link
Contributor

sounds great to me! we could do the same with the indenting spaces vs. tabs, however I've no idea how hard it would be to build so don't sink to much effort in it :)

@kubawerlos
Copy link
Contributor Author

@SpacePossum POC of the AutoReview changes: #5039

@SpacePossum SpacePossum removed the RTM Ready To Merge label Jul 3, 2020
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit f14f6da into PHP-CS-Fixer:2.16 Jul 3, 2020
@kubawerlos kubawerlos deleted the fix_SingleLineAfterImportsFixer2 branch July 3, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants