Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update composer.json to prevent issue #5030 #5083

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Update composer.json to prevent issue #5030 #5083

merged 1 commit into from
Aug 8, 2020

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Aug 1, 2020

Fixes for #5030 merged and released directly in Symfony.

This PR is per #5030 (comment) request to prevent CS fixer users hitting this issue.

@SpacePossum
Copy link
Contributor

Thanks @mvorisek !
Could you retarget this PR to 2.15 so the biggest group of users will benefit from it?

@mvorisek mvorisek changed the base branch from 2.16 to 2.15 August 6, 2020 09:56
@mvorisek mvorisek force-pushed the patch-2 branch 2 times, most recently from b7bb29e to 13909c8 Compare August 6, 2020 10:03
@mvorisek
Copy link
Contributor Author

mvorisek commented Aug 6, 2020 •
edited

Thanks @mvorisek !
Could you retarget this PR to 2.15 so the biggest group of users will benefit from it?

@SpacePossum done, Symfony support of version >=4 .1 <4.4 removed as EOL/unfixed

@kubawerlos kubawerlos added the RTM Ready To Merge label Aug 7, 2020
@julienfalque julienfalque added this to the 2.15.9 milestone Aug 8, 2020
@julienfalque
Copy link
Member

Thank you @mvorisek.

@julienfalque julienfalque merged commit 7732da5 into PHP-CS-Fixer:2.15 Aug 8, 2020
@julienfalque julienfalque removed the RTM Ready To Merge label Aug 8, 2020
@mvorisek mvorisek deleted the patch-2 branch August 8, 2020 08:21
@SpacePossum SpacePossum mentioned this pull request Aug 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

@kubawerlos kubawerlos kubawerlos approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.15.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mvorisek @SpacePossum @julienfalque @GrahamCampbell @kubawerlos