Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed invalid PHP 5.6 syntax #5100

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Fixed invalid PHP 5.6 syntax #5100

merged 1 commit into from
Aug 8, 2020

Conversation

GrahamCampbell
Copy link
Contributor

PHP 5.6 was outputting:

Warning: Unsupported declare 'strict_types' in /home/travis/build/FriendsOfPHP/PHP-CS-Fixer/tests/Tokenizer/Analyzer/SwitchAnalyzerTest.php on line 3
Warning: Unsupported declare 'strict_types' in /home/travis/build/FriendsOfPHP/PHP-CS-Fixer/tests/Tokenizer/Analyzer/Analysis/CaseAnalysisTest.php on line 3
Warning: Unsupported declare 'strict_types' in /home/travis/build/FriendsOfPHP/PHP-CS-Fixer/tests/Tokenizer/Analyzer/Analysis/SwitchAnalysisTest.php on line 3

@GrahamCampbell GrahamCampbell mentioned this pull request Aug 7, 2020
Merged
kubawerlos
kubawerlos approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some noob forgot to remove it.

@kubawerlos kubawerlos added the RTM Ready To Merge label Aug 7, 2020
@kubawerlos
Copy link
Contributor

To be precise is it "invalid PHP 5.6 syntax" or rather unsupported declaration?

@keradus keradus added this to the 2.15.9 milestone Aug 7, 2020
@julienfalque
Copy link
Member

Thank you @GrahamCampbell.

@julienfalque julienfalque merged commit 8bf516c into PHP-CS-Fixer:2.15 Aug 8, 2020
@julienfalque julienfalque removed the RTM Ready To Merge label Aug 8, 2020
@GrahamCampbell GrahamCampbell deleted the php56-fix branch August 8, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GrahamCampbell @kubawerlos @julienfalque @keradus