Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always lint test cases with the stricter process linter #5180

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Always lint test cases with the stricter process linter #5180

merged 1 commit into from
Oct 19, 2020

Conversation

GrahamCampbell
Copy link
Contributor

This will prevent invalid test cases like the ones removed by #5178.

@GrahamCampbell
Copy link
Contributor Author

GrahamCampbell commented Oct 15, 2020 •
edited

NB This also highlights a bunch of PHP 8 linting issues (which should be addressed in separate followup PRs).

@SpacePossum SpacePossum added this to the 2.15.9 milestone Oct 15, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Oct 15, 2020
@SpacePossum
Copy link
Contributor

SpacePossum commented Oct 15, 2020 •
edited

Thanks, looking good so far 👍
I'm going to try to fix all the tests in this PR as well to save me the trouble later.

@SpacePossum SpacePossum force-pushed the strict-linting branch 5 times, most recently from 822197d to 379376e Compare October 15, 2020 16:49
@GrahamCampbell
Copy link
Contributor Author

@SpacePossum I think this is ready for merge, followed by merges upwards, and then your other fixes PR for 2.16.

After that, I will PR some GitHub actions stuff to the 2.15 branch.

@SpacePossum
Copy link
Contributor

SpacePossum commented Oct 19, 2020 •
edited

Thank you @GrahamCampbell great to see this in :) 👍

@SpacePossum SpacePossum merged commit 2d444c4 into PHP-CS-Fixer:2.15 Oct 19, 2020
@GrahamCampbell GrahamCampbell deleted the strict-linting branch October 19, 2020 09:28
@keradus keradus mentioned this pull request Oct 26, 2020
Closed
@Wirone Wirone mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacePossum SpacePossum SpacePossum left review comments

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.15.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GrahamCampbell @SpacePossum