Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FinalStaticAccessFixer] Handle new static() in final class #5184

Merged
merged 1 commit into from
Oct 19, 2020
Merged

[FinalStaticAccessFixer] Handle new static() in final class #5184

merged 1 commit into from
Oct 19, 2020

Conversation

localheinz
Copy link
Member

This PR

  • handles new static() in final classes

💁‍♂️ Not sure, should I target the 2.15 branch instead?

@localheinz localheinz mentioned this pull request Oct 18, 2020
Merged
2 tasks
@localheinz
Copy link
Member Author

As far as I can tell, build failures are unrelated.

@julienfalque
Copy link
Member

Not sure, should I target the 2.15 branch instead?

The rule does not exist in 2.15 branch so we're good :)

@julienfalque julienfalque added this to the 2.16.5 milestone Oct 19, 2020
@SpacePossum SpacePossum mentioned this pull request Oct 19, 2020
Closed
62 tasks
@SpacePossum
Copy link
Contributor

Thank you @localheinz.

@SpacePossum SpacePossum merged commit d0f9be5 into PHP-CS-Fixer:2.16 Oct 19, 2020
@localheinz localheinz deleted the feature/final-static-access branch October 19, 2020 09:26
@localheinz
Copy link
Member Author

Thank you, @julienfalque and @SpacePossum!

@SpacePossum
Copy link
Contributor

👍
could you check if I did the merge conflict resolving on master OK?

@localheinz
Copy link
Member Author

@SpacePossum

Looking at the tests, this looks good to me!

👍

@SpacePossum
Copy link
Contributor

thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque julienfalque approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.16.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@localheinz @julienfalque @SpacePossum