Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YodaStyle - statements in braces should be treated as variables in strict … #5195

Merged
merged 1 commit into from
Oct 26, 2020
Merged

YodaStyle - statements in braces should be treated as variables in strict … #5195

merged 1 commit into from
Oct 26, 2020

Conversation

SpacePossum
Copy link
Contributor

…mode

closes #5154

@SpacePossum SpacePossum added this to the 2.15.9 milestone Oct 22, 2020
@SpacePossum SpacePossum marked this pull request as draft October 22, 2020 09:51
@SpacePossum SpacePossum marked this pull request as ready for review October 22, 2020 11:07
@SpacePossum
YodaStyle - rewrite same logic for more easy read
b3cb0fe 
YodaStyle - statements in braces should be treated as variables in strict mode
@SpacePossum SpacePossum added the RTM Ready To Merge label Oct 23, 2020
GrahamCampbell
GrahamCampbell approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Provided this has been tested on symfony/symfony.

@SpacePossum SpacePossum merged commit 74deddf into PHP-CS-Fixer:2.15 Oct 26, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Oct 26, 2020
@SpacePossum SpacePossum deleted the 2_15_yoda_fix branch October 26, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.15.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SpacePossum @GrahamCampbell